fix(dvcr): set Cap value for default backoff in dvcr importer#1992
Open
fix(dvcr): set Cap value for default backoff in dvcr importer#1992
Conversation
- Set Cap of 1m to limit delays for each step. - Set Steps to 20 to limit overall timeout to ~17 minutes to survive DVCR cleanup procedure. - Change logic behind Cap and Steps: always retry all steps, Cap is a maximum delay for the attempt, not a maximum delay that stop retrying. Signed-off-by: Иван Михейкин <ivan.mikheykin@flant.com>
7d35c18 to
2d5cad2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Default backoff without Cap leads to delays grows to more than 30m:
What is the expected result?
dvcr-importer retry delay is limited to around 1m
Retries after fix:
Checklist
Changelog entries