Skip to content

Added validation to vtex skuid #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aline-pereira wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added validation to vtex skuid #1488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99f279e
added validation to vtex skuid
aline-pereira Nov 26, 2025
455910d
fix logic
aline-pereira Dec 3, 2025
05b9bd7
check formatter
aline-pereira Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions vtex/loaders/legacy/productList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ const isFQProps = (p: any): p is FQProps => isValidArrayProp(p.fq);
// deno-lint-ignore no-explicit-any
const isTermProps = (p: any): p is TermProps => typeof p.term === "string";

const sanitizeNumericIds = (ids: string[] | undefined): string[] => {
return (ids || [])
.filter((id) => id && /^\d+$/.test(id.trim()))
.map((id) => id.trim());
};

const preferredSKU = (items: LegacyItem[], { props }: Props) => {
const fetchedSkus = new Set((props as SkuIDProps).ids ?? []);
return items.find((item) => fetchedSkus.has(item.itemId)) || items[0];
Expand All @@ -133,7 +139,7 @@ const fromProps = ({ props }: Props) => {
};

if (isSKUIDProps(props)) {
const skuIds = props.ids || [];
const skuIds = sanitizeNumericIds(props.ids);

skuIds.forEach((skuId) => params.fq.push(`skuId:${skuId}`));
params._from = 0;
Expand All @@ -143,7 +149,7 @@ const fromProps = ({ props }: Props) => {
}

if (isProductIDProps(props)) {
const productIds = props.productIds || [];
const productIds = sanitizeNumericIds(props.productIds);

productIds.forEach((productId) => params.fq.push(`productId:${productId}`));
params._from = 0;
Expand Down Expand Up @@ -303,14 +309,12 @@ export const cacheKey = (
]);

if (isSKUIDProps(props)) {
const skuIds = [...props.ids ?? []]?.sort();
const skuIds = sanitizeNumericIds(props.ids).sort();
params.append("skuids", skuIds.join(","));
}

if (
isProductIDProps(props)
) {
const productIds = [props.productIds ?? []].sort();
if (isProductIDProps(props)) {
const productIds = sanitizeNumericIds(props.productIds).sort();
params.append("productids", productIds.join(","));
}

Expand Down
Loading