Skip to content

fix(daemon): bump simple-git and enable allowUnsafeEditor#1168

Merged
guitavano merged 1 commit intomainfrom
fix/simple-git-allow-unsafe-editor
Apr 12, 2026
Merged

fix(daemon): bump simple-git and enable allowUnsafeEditor#1168
guitavano merged 1 commit intomainfrom
fix/simple-git-allow-unsafe-editor

Conversation

@guitavano
Copy link
Copy Markdown
Contributor

@guitavano guitavano commented Apr 12, 2026

Summary

  • Bumps simple-git from ^3.25.0 to ^3.36.0 in deno.json
  • Adds unsafe: { allowUnsafeEditor: true } to the simpleGit() options in daemon/git.ts

Context

simple-git >= 3.27 introduced a security plugin that blocks setting core.editor via the config option unless allowUnsafeEditor is explicitly enabled. The daemon sets core.editor=true intentionally (to prevent git from opening an interactive editor and blocking execution), but the newer version was throwing:

GitPluginError: Configuring core.editor is not permitted without enabling allowUnsafeEditor

This fix keeps the existing behavior while satisfying the library new opt-in requirement.

Made with Cursor


Summary by cubic

Bump simple-git to ^3.36.0 and enable unsafe.allowUnsafeEditor so the daemon can keep setting core.editor=true without opening an editor or throwing GitPluginError at startup.

Written for commit 27b6965. Summary will update on new commits.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated simple-git dependency to a newer version.
    • Enhanced git configuration settings.

simple-git >= 3.27 blocks setting core.editor via the config option
unless allowUnsafeEditor is explicitly set. Bump the pinned version
to 3.36.0 and pass unsafe.allowUnsafeEditor: true so the git instance
no longer throws GitPluginError at startup.

Made-with: Cursor
@github-actions
Copy link
Copy Markdown
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 1.195.4 update
  • 🎉 for Minor 1.196.0 update
  • 🚀 for Major 2.0.0 update

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9717b785-9881-4186-964b-7db094c1dd39

📥 Commits

Reviewing files that changed from the base of the PR and between 3263ca3 and 27b6965.

📒 Files selected for processing (2)
  • daemon/git.ts
  • deno.json

📝 Walkthrough

Walkthrough

The simple-git dependency was upgraded from version 3.25.0 to 3.36.0. The git daemon configuration was enhanced by adding an allowUnsafeEditor: true setting to the existing simpleGit initialization alongside the core editor configuration.

Changes

Cohort / File(s) Summary
Dependency Management
deno.json
Updated simple-git npm package from ^3.25.0 to ^3.36.0.
Git Configuration
daemon/git.ts
Added unsafe option with allowUnsafeEditor: true to simpleGit initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A version bump, so quick and neat,
Editor safety—a small treat!
Simple-git now flows so free,
With unsafe-true, we can be we!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes both main changes: bumping simple-git version and enabling allowUnsafeEditor option, which directly corresponds to the file modifications in daemon/git.ts and deno.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/simple-git-allow-unsafe-editor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@guitavano guitavano merged commit a8bef24 into main Apr 12, 2026
5 of 6 checks passed
@guitavano guitavano deleted the fix/simple-git-allow-unsafe-editor branch April 12, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant