fix(daemon): bump simple-git and enable allowUnsafeEditor#1168
fix(daemon): bump simple-git and enable allowUnsafeEditor#1168
Conversation
simple-git >= 3.27 blocks setting core.editor via the config option unless allowUnsafeEditor is explicitly set. Bump the pinned version to 3.36.0 and pass unsafe.allowUnsafeEditor: true so the git instance no longer throws GitPluginError at startup. Made-with: Cursor
Tagging OptionsShould a new tag be published when this PR is merged?
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe simple-git dependency was upgraded from version 3.25.0 to 3.36.0. The git daemon configuration was enhanced by adding an Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Context
simple-git >= 3.27 introduced a security plugin that blocks setting core.editor via the config option unless allowUnsafeEditor is explicitly enabled. The daemon sets core.editor=true intentionally (to prevent git from opening an interactive editor and blocking execution), but the newer version was throwing:
This fix keeps the existing behavior while satisfying the library new opt-in requirement.
Made with Cursor
Summary by cubic
Bump
simple-gitto ^3.36.0 and enableunsafe.allowUnsafeEditorso the daemon can keep settingcore.editor=truewithout opening an editor or throwingGitPluginErrorat startup.Written for commit 27b6965. Summary will update on new commits.
Summary by CodeRabbit
Release Notes