DE-8810: Pipeline SDK shouldn't mark kafka as a dependency#81
Merged
nicoweidner merged 15 commits intomainfrom Apr 28, 2025
Merged
DE-8810: Pipeline SDK shouldn't mark kafka as a dependency#81nicoweidner merged 15 commits intomainfrom
nicoweidner merged 15 commits intomainfrom
Conversation
…from shadow, use explicit configuration excludeFromShadow for that purpose; make flink-connector-kafka a testImplementation dependency of the example project as it is now bundled with our Flink images
…fka from example (that would exclude Jackson)
hpgrahsl
approved these changes
Apr 22, 2025
Contributor
hpgrahsl
left a comment
hpgrahsl
left a comment
There was a problem hiding this comment.
THX! This looks good to go. After merging this we need to check if the release workflow needs to be adapted too, based on some of the changes you had introduced to the ci workflow.
|
🎉 This issue has been resolved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before we create a release with this change, we need to release new Flink images that actually bundle our Kafka connector fork, and document the changes