-
Notifications
You must be signed in to change notification settings - Fork 140
Add Wii U platform with ghs 5.3.22 #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great stuff - thanks for this! Could you add |
|
Just tried to run this locally and get looks like the path is wrong (needs cc='${WIBO} "${COMPILER_DIR}/bin/cxppc.exe" -c ${COMPILER_FLAGS} -o "${OUTPUT}" "${INPUT}"'edit edit2 which seems to be because the compiler is implicitly passed |
|
|
I just created a simple scratch locally to test the change. The invocation output is from passing |
|
I think |
|
Could try just |
|
I think this is better (tested locally): GHS5322 = GHSCompiler(
id="ghs5.3.22",
platform=WIIU,
cc='${WINE} "${COMPILER_DIR}/bin/cxppc.exe" -c -tmp="${OUTPUT}".s ${COMPILER_FLAGS} -o "${OUTPUT}" "${INPUT}"'
) |
|
For the biome and ruff, I would do the following (assuming you have done docker compose exec -ti backend uv run ruff format coreapp
docker compose exec -ti frontend yarn formatif you want I can run these and push a commit with the changes. |
|
Yes that would be appreciated, thank you |
|
Hmm, looks like you didnt allow edits by maintainers? If you want to make the changes manually the diff is here. or if you allow edits I can push to your branch. |
|
I have applied the changes |
|
OK I've fixed up the SVG properly (I thought mine was broken, but yours was too): <?xml version="1.0" encoding="UTF-8"?>
<svg version="1.1" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
<path d="m12.005 11.124c0 6.7553 7.9892 5.7888 7.9892 1.0654v-11.189h-7.9892z" clip-rule="evenodd" fill="#02abca" fill-rule="evenodd"/>
<path d="m1 18.218c0 3.3391 2.3053 5.3255 5.68 5.3255h19.171c2.8459 0 5.1492-1.9666 5.1492-4.7927v-14.024c0-1.7032-1.0545-3.7273-2.625-3.7273h-4.875v11.887c0 8.7636-15.044 8.518-15.044 0v-11.887h-3.3668c-2.1964 0-4.0838 1.3864-4.0838 3.549z" clip-rule="evenodd" fill="#02abca" fill-rule="evenodd"/>
</svg> |
|
Updated |

Related PR: decompme/compilers#51