Skip to content

Tweak scratch match banner text (lower -> better) #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkst merged 1 commit into from
Dec 9, 2025
Merged

Tweak scratch match banner text (lower -> better) #1768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions frontend/src/components/Scratch/ScratchMatchBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,25 @@ export default function ScratchMatchBanner({

if (scratch.score === 0 || !match) return null;

const isMatch = match.score === 0;
const isMatch = match.score === 0 || match.match_override;
const subject = userIsYou(match.owner)
? "You have"
: `${match.owner?.username ?? "A user"} has`;

const percent = calculateScorePercent(match.score, match.max_score);
const percentString = percent !== 0 ? percentToString(percent) : "";
const percent = !isMatch
? calculateScorePercent(match.score, match.max_score)
: null;
const percentString = percent ? ` (${percentToString(percent)})` : "";

let message = `This function has ${isMatch ? "been matched" : "a lower-scoring scratch"}`;
if (userIsYou(match.owner)) message += " by you, elsewhere";
else if (match.owner) message += ` by ${match.owner.username}`;

if (!isMatch)
message += `. Improved score is ${match.score.toLocaleString("en-US")} ${percentString && `(${percentString})`}`;
const message = isMatch
? `${subject} matched this scratch elsewhere. `
: `${subject} a better scoring scratch elsewhere. The improved score is ${match.score.toLocaleString("en-US")}${percentString}. `;

return (
<DismissableBanner color={isMatch ? "#951fd9" : "#4273e1"}>
{message}.{" "}
{message}
<Link href={scratchUrl(match)}>
View {match.score === 0 ? "match" : "improvement"}
View {isMatch ? "match" : "improvement"}
</Link>
</DismissableBanner>
);
Expand Down