Open
Conversation
Member
|
@bgptr can you please rebase this? |
Collaborator
Author
|
@dajohi Sure. I will do it asap. |
+ globalThis.IS_REACT_ACT_ENVIRONMENT = true; + update @testing-library/* + fix tests
bgptr
force-pushed
the
react-v18
branch
4 times, most recently
from
771887d to
41db4aa
Compare
…from the selector. Thus decreasing interference of the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first step toward #3842
This diff updates to React v18 and enjoys the benefit of automatic performance improvement. It does not take further steps toward the new features, but it will be a good starting point.
The biggest issue was the
react-hot-loader, which is not maintained anymore and is not compatible with v18. I successfully replaced it withReact Fast Refreshthough, which is the recommended way.@testing-library/*libraries also have been updated and the tests are fixed.On top of this, we can gradually adopt the new features:
startTransitionuseDeferredValueTested on Linux, and macOS (amd64).