Fix iframe issue | Dark Mode | Improve UI & input targeting#78
Fix iframe issue | Dark Mode | Improve UI & input targeting#78xenos1337 wants to merge 5 commits intodedoussis:mainfrom
Conversation
|
Hello @xenos1337, Huge thanks for submitting this PR and addressing all these issues. This is really appreciated! Since this PR covers an array of different issues and introduces large code changes, would it be possible to split it into separate PRs (ideally 1 PR per each change/fix mentioned in your description)? I would suggest starting with the iframe and XPath fixes, as they're simpler to review and ship, which would help minimize potential rebases between your branches. The only early, high level feedback I can give right now is:
|
|
Hi @xenos1337! I wanted to fix the iframe issue and was wondering if you were still planning to work on this PR. |
I'm sorry yes I will, I'm currently very busy but I'll make sure to get this pushed in the next few days |
|
@xenos1337 No rush at all! Take your time. I just wanted to check before picking any of those issues up. |
Changes/fixes:
Enable content script in all frames
Add dark mode switcher
Migrate options page to popup
Add XPath support for input element targeting
Tests
I went ahead and tested all features and they work like intented