Skip to content

Add support for record id of bytes type #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmores wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for record id of bytes type #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dedupe/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ def sniff_id_type(ids: Sequence[tuple[RecordID, RecordID]]) -> RecordIDDType:
elif python_type is int:
int(example) # make sure we can cast to int
dtype = int
elif python_type is bytes:
dtype = (bytes, 256) # type: ignore[assignment]
else:
raise ValueError("Invalid type for record id")

Expand Down