Skip to content

did a check on publicPath with a default #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thescientist13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

did a check on publicPath with a default #5

thescientist13 wants to merge 1 commit into from

Conversation

@thescientist13
Copy link

@thescientist13 thescientist13 commented Nov 18, 2017 •
edited
Loading

resolves #4 by fixing an undefined error

not sure if this the best solution, but works for me locally in Chrome
screen shot 2017-11-17 at 11 08 14 pm

screen shot 2017-11-17 at 11 08 21 pm

@thescientist13
Copy link
Author

thescientist13 commented Nov 18, 2017

As reported in #4 , I was trying to use images from FaviconsWebpackPlugin, but not seeing that show up in the manifest tab above ^. Related to #2 , or should I open a new issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'length' of undefined

1 participant

@thescientist13