Closed
Conversation
- Add type hints for function parameters and return values - Import typing.Optional for better type annotations - Improves code readability and IDE support for Python 3.13.5 Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
…iables - Extract logging setup into setup_logging() function - Extract authentication logic into authenticate_client() function - Add proper main() function as entry point - Pass dependencies as function parameters instead of using globals - Use SystemExit with proper exit codes instead of bare exit() - Add input validation for required environment variables Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
- Define constants for default values and magic strings - Use constants instead of hard-coded values throughout the code - Add docstring to fetch_and_process function - Improves maintainability and reduces duplication Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
- Add validate_environment() function to check required env vars early - Validate DAYS_AGO is a valid non-negative integer - Add proper error handling for integer parsing - Provide clear error messages for validation failures - Simplify authenticate_client by removing redundant checks Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
- Use f-string for client_method construction instead of concatenation - Remove unnecessary parentheses in if condition - Use 'not dry_run' instead of 'dry_run == False' for better readability - Fix error message to be singular instead of plural - Follows PEP 8 style guidelines and modern Python practices Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
- Add detailed docstrings for all classes and functions - Include parameter descriptions, return values, and exceptions - Follow Google/NumPy docstring style conventions - Improves code maintainability and IDE support Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
- Add comprehensive module docstring describing the tool's purpose - Document features, environment variables, and usage - Include author information - Follows Python documentation best practices Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
- Convert 2-space indentation to 4-space (PEP 8 standard) - Ensure consistent indentation throughout the file - Improves code readability and follows Python style guidelines Co-authored-by: Danielle Heberling <12616554+deeheber@users.noreply.github.com>
Owner
Author
|
closing in favor of #16 it did do the right thing ish...but took a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #14 because the kiro agent (in preview to be fair) is going off the walls a bit. I'd rather do it myself at this point. 😄