Skip to content

LLM-5888 Minor avoid overriding STARTAPP for simplicity #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniilyar-deepchecks wants to merge 1 commit into from
Closed

LLM-5888 Minor avoid overriding STARTAPP for simplicity #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bin/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ fi
STARTAPP="uvicorn --factory deepchecks_monitoring.app:create_application --host 0.0.0.0 --workers 4 --log-level debug --proxy-headers --forwarded-allow-ips '*'"

if [[ -v DD_ENV ]]; then
STARTAPP="ddtrace-run ${STARTAPP}"
# Run ddtrace with uvicorn as a pid 1 in the container (pass pid 1 in the container from bash to ddtrace)
exec ddtrace-run ${STARTAPP}
fi

exec ${STARTAPP}
# Run Uvicorn as a pid 1 in the container (pass pid 1 in the container from bash to Unicorn)
exec ${STARTAPP}
Loading