Skip to content

update-redis-settings #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JKL98ISR merged 3 commits into from
Apr 14, 2025
Merged

update-redis-settings #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77ccf8a
update-redis-settings
JKL98ISR Apr 14, 2025
e766ca1
update-redis-settings
JKL98ISR Apr 14, 2025
aec04a9
update-redis-settings
JKL98ISR Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/license-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ jobs:
with:
requirements: "backend/requirements-all.txt"
fail: "Copyleft,Other,Error"
exclude: '(category_encoders.*2\.7\..*|attrs.*25\.3\..*|referencing.*0\.36\..*|envier.*0\.5\.0|psycopg2.*2\.9\.3|fqdn.*1\.5\.1|pyzmq.*25\.1\.2|debugpy.*1\.6\.7|certifi.*2025\.1\.31|tqdm.*4\.67\..*|webencodings.*0\.5\.1|torch.*1\.10\.2.*|torch.*1\.11\.0.*|pytorch-ignite.*0\.4\.10.*|torchaudio.*0\.11\.0.*|torchvision.*0\.12\.0.*|terminado.*0\.15\.0|qudida.*0\.0\.4|expiringdict.*1\.2\.2|botocore.*1\.29\.80|orderedmultidict.*1\.0\.1|termcolor.*3\.0\.1|deepchecks.*)' # psycopg2 is LGPL 2
exclude: '(category_encoders.*2\.7\..*|attrs.*25\.3\..*|referencing.*0\.36\..*|envier.*0\.5\.0|psycopg2.*2\.9\.3|fqdn.*1\.5\.1|pyzmq.*25\.1\.2|debugpy.*1\.6\.7|certifi.*2025\.1\.31|tqdm.*4\.67\..*|webencodings.*0\.5\.1|torch.*1\.10\.2.*|torch.*1\.11\.0.*|pytorch-ignite.*0\.4\.10.*|torchaudio.*0\.11\.0.*|torchvision.*0\.12\.0.*|terminado.*0\.15\.0|qudida.*0\.0\.4|expiringdict.*1\.2\.2|botocore.*1\.29\.80|orderedmultidict.*1\.0\.1|termcolor.*3\.0\.1|pillow.*11\.2\.1|deepchecks.*)'
# psycopg2 is LGPL 2
# category_encoders is BSD https://github.com/scikit-learn-contrib/category_encoders/tree/master?tab=BSD-3-Clause-1-ov-file
# attrs is MIT https://github.com/python-attrs/attrs/blob/main/LICENSE
# referencing is MIT https://github.com/python-jsonschema/referencing?tab=MIT-1-ov-file
Expand Down
2 changes: 0 additions & 2 deletions backend/deepchecks_monitoring/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ class RedisSettings(BaseDeepchecksSettings):
"""Redis settings."""

redis_uri: t.Optional[RedisDsn] = None
socket_connect_timeout: int = 5
socket_timeout: int = 5
socket_keepalive: bool = True
retry_attempts: int = 6
cluster_error_retry_attempts: int = 2
Expand Down
2 changes: 0 additions & 2 deletions backend/deepchecks_monitoring/utils/redis_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ def create_settings_dict(redis_settings: RedisSettings):

return dict(
url=redis_settings.redis_uri,
socket_connect_timeout=redis_settings.socket_connect_timeout,
socket_timeout=redis_settings.socket_timeout,
socket_keepalive=redis_settings.socket_keepalive,
retry=Retry(ExponentialBackoff(), redis_settings.retry_attempts),
)
Expand Down
Loading