Skip to content

remove unnecessary catch #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JKL98ISR merged 1 commit into from
Apr 15, 2025
Merged

remove unnecessary catch #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions backend/deepchecks_monitoring/bgtasks/tasks_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,20 +77,14 @@ async def run(self):
raise

async def wait_for_task(self, timeout=120):
try:
task_entry = await self.redis.bzpopmin(GLOBAL_TASK_QUEUE, timeout=timeout)
except redis_exceptions.TimeoutError:
self.logger.info('Got timeout from redis queue polling task_id ')
task_entry = await self.redis.bzpopmin(GLOBAL_TASK_QUEUE, timeout=timeout)
if task_entry is None:
self.logger.info('Got from redis queue task_id none')
return
else:
if task_entry is None:
self.logger.info('Got from redis queue task_id none')
return
else:
# Return value from redis is (redis key, value, score)
task_id = int(task_entry[1].decode())
queued_timestamp: int = task_entry[2]
return task_id, queued_timestamp
# Return value from redis is (redis key, value, score)
task_id = int(task_entry[1].decode())
queued_timestamp: int = task_entry[2]
return task_id, queued_timestamp

async def run_single_task(self, task_id, session, queued_timestamp):
"""Run single task."""
Expand Down
Loading