Skip to content

align all the records generated with latest schema #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TejasMorbagal merged 38 commits into from
Mar 18, 2025
Merged

align all the records generated with latest schema #6

TejasMorbagal merged 38 commits into from
Mar 18, 2025

Conversation

@TejasMorbagal
Copy link
Member

@TejasMorbagal TejasMorbagal commented Mar 12, 2025 •
edited
Loading

This PR includes the changes implemented to generate valid records which aligns with latest OSC-schema

Testing strategy:

  1. I have avoided complex mocking to have unit tests which are more maintainable.
  2. To test the publish feature, there is an option 'write_to_file' to allow generation of files locally.
  3. For integration test, we have a testing-repo to check if the files generated pass the validation checks.

@TejasMorbagal
current state
f78e7dd
@TejasMorbagal
introduced new constants and re-adding self-links
755c51e
@TejasMorbagal
fix updating var base catalog
3a962eb
@TejasMorbagal
refactored add themes as links
8647f45
@TejasMorbagal
refactor
3d2d68c
@TejasMorbagal
implemented ogc api record generation for workflow and experiment
1ab4461
@TejasMorbagal
implementation works to generate valid ogc api records for experiment…
d2591db 
…s and workflows
@TejasMorbagal
update github_automation class to fork only if local clone dir doesn'…
c883649 
…t exist, added write_to_file option for local testing during development
@TejasMorbagal
extract repeated logic into helper methods
5b403a1
@TejasMorbagal
refactor to remove comments
7769721
@TejasMorbagal
refactor to remove comments
9ae54f6
@TejasMorbagal
combined publish methods to create a single GitHub PR
03981a6
@TejasMorbagal
added lint with ruff to CI
adee40e
@TejasMorbagal
ruff lint checks
19c6b21
@TejasMorbagal
update cli command to publish all files in one PR
94a3452
@TejasMorbagal
updated ci to install ruff explicitly
7d7dc7d
@TejasMorbagal
updated ci
457813d
This was linked to issues Mar 12, 2025
Removal of osc:themes #4
Closed
Typo in target path specification for variables in OscDatasetStacGenerator #5
Closed
@TejasMorbagal TejasMorbagal added the enhancement New feature or request label Mar 12, 2025
@TejasMorbagal TejasMorbagal self-assigned this Mar 12, 2025
@TejasMorbagal TejasMorbagal marked this pull request as draft March 12, 2025 17:03
@TejasMorbagal TejasMorbagal marked this pull request as ready for review March 14, 2025 14:27
@TejasMorbagal TejasMorbagal requested a review from forman March 14, 2025 14:31
thomasstorm
thomasstorm requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md still refers to the old way. Please update that file accordingly.

@thomasstorm
Copy link
Collaborator

thomasstorm commented Mar 18, 2025

Looks good - I have added quite a lot of comments, but none of them are severe -- apart from the README.md update, which is necessary.

@TejasMorbagal TejasMorbagal merged commit 43e3aea into main Mar 18, 2025
1 check passed
TejasMorbagal added a commit that referenced this pull request Mar 26, 2025
@TejasMorbagal
addressed suggestions to PR #6
fdb350d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasstorm thomasstorm thomasstorm requested changes

@forman forman Awaiting requested review from forman

Assignees

@TejasMorbagal TejasMorbagal

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in target path specification for variables in OscDatasetStacGenerator Removal of osc:themes

3 participants

@TejasMorbagal @thomasstorm