Skip to content

Scan non executable files, fix severity#117

Merged
ramanan-ravi merged 4 commits intomainfrom
severity
Apr 10, 2025
Merged

Scan non executable files, fix severity#117
ramanan-ravi merged 4 commits intomainfrom
severity

Conversation

@ramanan-ravi
Copy link
Contributor

Scanning container image quay.io/petr_ruzicka/malware-cryptominer-container skips every file because they are not executable ones

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

pkg/scan/process_image.go:242

  • Ensure that the new delimiter (' = ') used for splitting meta rule strings is consistent with how meta data is formatted elsewhere. If rule definitions still use the colon delimiter, this change could lead to unexpected behavior in meta data parsing.
var metaSplit = strings.Split(c, " = ")

config.yaml:6

  • Double-check that disabling the skipping of non-executable files aligns with the intended scanning behavior for this container image, ensuring no unwanted files are processed.
skip_non_executable: false

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ramanan-ravi ramanan-ravi merged commit 408a462 into main Apr 10, 2025
1 check passed
@ramanan-ravi ramanan-ravi deleted the severity branch April 10, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments