Scan non executable files, fix severity#117
Merged
ramanan-ravi merged 4 commits intomainfrom Apr 10, 2025
Merged
Conversation
gnmahanth
approved these changes
Apr 10, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
pkg/scan/process_image.go:242
- Ensure that the new delimiter (' = ') used for splitting meta rule strings is consistent with how meta data is formatted elsewhere. If rule definitions still use the colon delimiter, this change could lead to unexpected behavior in meta data parsing.
var metaSplit = strings.Split(c, " = ")
config.yaml:6
- Double-check that disabling the skipping of non-executable files aligns with the intended scanning behavior for this container image, ensuring no unwanted files are processed.
skip_non_executable: false
gnmahanth
approved these changes
Apr 10, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scanning container image quay.io/petr_ruzicka/malware-cryptominer-container skips every file because they are not executable ones