Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
d85dfe4
First pass at wildcards for test cases
stanbrub Sep 16, 2025
24e556b
Change test case regex to wildcard
stanbrub Sep 16, 2025
db3a7bc
Add debug for bad command
stanbrub Sep 16, 2025
427916b
Add debug for bad command
stanbrub Sep 16, 2025
e93386c
Quoting issues
stanbrub Sep 16, 2025
7fcd98b
Cleaned up naming from regex
stanbrub Sep 16, 2025
51b3606
Echo run benchmark arguments
stanbrub Sep 16, 2025
f85c9b2
Debug code
stanbrub Sep 17, 2025
c530ce4
Try disabling wildcard expansion
stanbrub Sep 17, 2025
b716040
fixed tabs
stanbrub Sep 17, 2025
68a58ba
Sigh
stanbrub Sep 17, 2025
4002121
more debug for asterisk
stanbrub Sep 17, 2025
2ff9abf
Trial and error for asterisk passing
stanbrub Sep 17, 2025
ff8ee3f
Again
stanbrub Sep 17, 2025
d02cf5b
Again
stanbrub Sep 17, 2025
5640283
Debug
stanbrub Sep 17, 2025
ec546c2
Debug
stanbrub Sep 17, 2025
214cea3
Debug
stanbrub Sep 17, 2025
2e0fef7
Debug
stanbrub Sep 17, 2025
5c109d9
Try ampersand with args
stanbrub Sep 18, 2025
1826156
More asterisk fun
stanbrub Sep 18, 2025
017a308
Debug asterisk
stanbrub Sep 18, 2025
fb3a250
More asterisk debug
stanbrub Sep 18, 2025
0208a5b
Asterisk
stanbrub Sep 18, 2025
0932241
a1000
stanbrub Sep 19, 2025
20acb08
a1001
stanbrub Sep 19, 2025
3fe99ff
a1002
stanbrub Sep 19, 2025
f90554d
a1003
stanbrub Sep 19, 2025
cdd657e
a1004
stanbrub Sep 19, 2025
c4e6c0e
a1005
stanbrub Sep 19, 2025
b117d7c
a1006
stanbrub Sep 19, 2025
12fb715
spaces again
stanbrub Sep 19, 2025
d011d5b
Upgraded the barrage client and other versions
stanbrub Sep 23, 2025
6f228c2
Merge branch 'deephaven:main' into move-wildcard-test-case-into-java
stanbrub Sep 25, 2025
2534790
Updated adhoc docker service versions
stanbrub Sep 30, 2025
b6f0a2b
Updated docker compose versions
stanbrub Sep 30, 2025
9a77bc6
Remvoed Keyed Transpose experimental test.
stanbrub Sep 30, 2025
eb8b918
Removed some debug
stanbrub Sep 30, 2025
97b8237
Removed more debug
stanbrub Sep 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/distro/benchmark.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ if [[ $# != 2 ]]; then
fi

ITERATIONS=$1
TEST_WILD=$2
TEST_WILD="$2"
BENCH_MAIN="io.deephaven.benchmark.run.BenchmarkMain"
TEST_PACKAGE="io.deephaven.benchmark.tests.standard"

Expand All @@ -43,19 +43,12 @@ sudo docker compose up -d
sleep 5
set -f

TEST_REGEX="^.*[.]("
for r in $(echo "${TEST_WILD}" | sed 's/\s*,\s*/ /g'); do
TEST_REGEX="${TEST_REGEX}"$(echo "(${r}Test)|" | sed 's/\*/.*/g')
done
TEST_REGEX=$(echo ${TEST_REGEX} | sed -E 's/\|+$//g')
TEST_REGEX="${TEST_REGEX})$"

for i in `seq 1 ${ITERATIONS}`
do

echo "*** Starting Iteration: $i ***"

java -Dbenchmark.profile=benchmark.properties -cp "libs/*" ${BENCH_MAIN} -p ${TEST_PACKAGE} -n "${TEST_REGEX}"
java -Dbenchmark.profile=benchmark.properties -cp "libs/*" ${BENCH_MAIN} -p ${TEST_PACKAGE} -n "${TEST_WILD}"

done

Expand Down
6 changes: 3 additions & 3 deletions .github/resources/adhoc-benchmark-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ services:
- PLAINTEXT://redpanda:29092,OUTSIDE://localhost:9092
- --pandaproxy-addr 0.0.0.0:8082
- --advertise-pandaproxy-addr redpanda:8082
image: redpandadata/redpanda:v25.1.2
image: redpandadata/redpanda:v25.2.5
ports:
- 8081:8081
- 8082:8082
- 9092:9092
- 29092:29092

minio-server:
image: minio/minio:RELEASE.2025-04-22T22-12-26Z
image: minio/minio:RELEASE.2025-09-07T16-13-09Z
command: server /minio --console-address ":9001"
hostname: minio
environment:
Expand All @@ -59,7 +59,7 @@ services:
- ./minio:/minio

minio-bucket:
image: minio/mc:RELEASE.2025-04-16T18-13-26Z
image: minio/mc:RELEASE.2025-08-13T08-35-41Z
depends_on:
- minio-server
entrypoint: >
Expand Down
2 changes: 1 addition & 1 deletion .github/resources/compare-benchmark-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ services:
- PLAINTEXT://redpanda:29092,OUTSIDE://localhost:9092
- --pandaproxy-addr 0.0.0.0:8082
- --advertise-pandaproxy-addr redpanda:8082
image: redpandadata/redpanda:v25.1.2
image: redpandadata/redpanda:v25.2.5
ports:
- 8081:8081
- 8082:8082
Expand Down
2 changes: 1 addition & 1 deletion .github/resources/integration-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ services:
- PLAINTEXT://redpanda:29092,OUTSIDE://localhost:9092
- --pandaproxy-addr 0.0.0.0:8082
- --advertise-pandaproxy-addr redpanda:8082
image: redpandadata/redpanda:v25.1.2
image: redpandadata/redpanda:v25.2.5
ports:
- 8081:8081
- 8082:8082
Expand Down
6 changes: 3 additions & 3 deletions .github/resources/nightly-benchmark-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ services:
- PLAINTEXT://redpanda:29092,OUTSIDE://localhost:9092
- --pandaproxy-addr 0.0.0.0:8082
- --advertise-pandaproxy-addr redpanda:8082
image: redpandadata/redpanda:v25.1.2
image: redpandadata/redpanda:v25.2.5
ports:
- 8081:8081
- 8082:8082
- 9092:9092
- 29092:29092

minio-server:
image: minio/minio:RELEASE.2025-04-22T22-12-26Z
image: minio/minio:RELEASE.2025-09-07T16-13-09Z
command: server /minio --console-address ":9001"
hostname: minio
environment:
Expand All @@ -59,7 +59,7 @@ services:
- ./minio:/minio

minio-bucket:
image: minio/mc:RELEASE.2025-04-16T18-13-26Z
image: minio/mc:RELEASE.2025-08-13T08-35-41Z
depends_on:
- minio-server
entrypoint: >
Expand Down
6 changes: 3 additions & 3 deletions .github/resources/release-benchmark-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ services:
- PLAINTEXT://redpanda:29092,OUTSIDE://localhost:9092
- --pandaproxy-addr 0.0.0.0:8082
- --advertise-pandaproxy-addr redpanda:8082
image: redpandadata/redpanda:v25.1.2
image: redpandadata/redpanda:v25.2.5
ports:
- 8081:8081
- 8082:8082
- 9092:9092
- 29092:29092

minio-server:
image: minio/minio:RELEASE.2025-04-22T22-12-26Z
image: minio/minio:RELEASE.2025-09-07T16-13-09Z
command: server /minio --console-address ":9001"
hostname: minio
environment:
Expand All @@ -59,7 +59,7 @@ services:
- ./minio:/minio

minio-bucket:
image: minio/mc:RELEASE.2025-04-16T18-13-26Z
image: minio/mc:RELEASE.2025-08-13T08-35-41Z
depends_on:
- minio-server
entrypoint: >
Expand Down
16 changes: 0 additions & 16 deletions .github/scripts/adhoc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,6 @@ if [[ ${ACTION} == "make-labels" ]]; then
echo "SET_LABEL_2=${LABEL2}" | tee -a ${OUTPUT_NAME}
fi

# Make a regex from a list of wilcarded test class names
if [[ ${ACTION} == "make-test-regex" ]]; then
WILDCARDS=$2
echo "Making Test Regex: ${WILDCARDS}"

TEST_REGEX="^.*[.]("
for r in $(echo ${WILDCARDS} | sed 's/\s*,\s*/ /g'); do
TEST_REGEX="${TEST_REGEX}"$(echo "(${r}Test)|" | sed 's/\*/.*/g')
done
TEST_REGEX=$(echo ${TEST_REGEX} | sed -E 's/\|+$//g')
TEST_REGEX="${TEST_REGEX})$"

echo "WILDCARDS=${WILDCARDS}" | tee -a ${OUTPUT_NAME}
echo "TEST_CLASS_REGEX=${TEST_REGEX}" | tee -a ${OUTPUT_NAME}
fi

# Format some number used for scaling the tests
if [[ ${ACTION} == "scale-nums" ]]; then
INPUT_ROW_COUNT=$2
Expand Down
7 changes: 5 additions & 2 deletions .github/scripts/run-benchmarks-remote.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
set -o errexit
set -o pipefail
set -o nounset
set -f

# Copyright (c) 2023-2024 Deephaven Data Labs and Patent Pending

Expand All @@ -13,7 +14,7 @@ set -o nounset
# Note: Assumes the deephaven-benchmark-*.jar artifact has been built and placed

if [[ $# != 6 ]]; then
echo "$0: Missing run type, test package, test regex, row count, distribution, or tag name"
echo "$0: Missing run type, test package, test classes, row count, distribution, or tag name"
exit 1
fi

Expand All @@ -39,9 +40,11 @@ title "- Running Remote Benchmark Artifact on ${HOST} -"
cd ${DEEPHAVEN_DIR};

title "-- Running Benchmarks --"
set +f
cd ${RUN_DIR}
cat ${RUN_TYPE}-scale-benchmark.properties | sed 's|${baseRowCount}|'"${ROW_COUNT}|g" | sed 's|${baseDistrib}|'"${DISTRIB}|g" > scale-benchmark.properties
JAVA_OPTS="-Dbenchmark.profile=scale-benchmark.properties -jar deephaven-benchmark-*-standalone.jar -cp standard-tests.jar"
JAVA_OPTS=$(echo -Dbenchmark.profile=scale-benchmark.properties -jar deephaven-benchmark-*-standalone.jar -cp standard-tests.jar)
set -f

if [ "${TAG_NAME}" = "Any" ]; then
java ${JAVA_OPTS} -p ${TEST_PACKAGE} -n "${TEST_PATTERN}"
Expand Down
7 changes: 4 additions & 3 deletions .github/scripts/run-ssh-local.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
set -o errexit
set -o pipefail
set -o nounset
set -f

# Copyright (c) 2023-2024 Deephaven Data Labs and Patent Pending

Expand All @@ -11,8 +12,8 @@ set -o nounset
# remote scripts in single-quotes to avoid syntax errors.

if [[ $# -lt 4 ]]; then
echo "$0: Missing host, user, script dir, or script name argument"
exit 1
echo "$0: Missing host, user, script dir, or script name argument"
exit 1
fi

HOST=$1
Expand All @@ -25,4 +26,4 @@ for i in ${@:5}; do
args+=("'"$i"'")
done

ssh -o 'ServerAliveInterval 60' ${USER}@${HOST} 'bash -s' "${args[*]}" < ${SCRIPT_DIR}/${SCRIPT_NAME}.sh |& tee logs/${SCRIPT_NAME}.log
ssh -o 'ServerAliveInterval 60' ${USER}@${HOST} 'bash -s' -- "${args[@]}" < ${SCRIPT_DIR}/${SCRIPT_NAME}.sh |& tee logs/${SCRIPT_NAME}.log
11 changes: 2 additions & 9 deletions .github/workflows/adhoc-auto-remote-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ jobs:
outputs:
set_label_1: ${{ steps.make-labels.outputs.SET_LABEL_1 }}
set_label_2: ${{ steps.make-labels.outputs.SET_LABEL_2 }}
test_class_regex: "${{ steps.make-test-regex.outputs.TEST_CLASS_REGEX }}"
metal_device_id: ${{ steps.deploy-metal.outputs.DEVICE_ID }}
metal_device_name: ${{ steps.deploy-metal.outputs.DEVICE_NAME }}
metal_ip_addr: ${{ steps.deploy-metal.outputs.DEVICE_ADDR }}
Expand All @@ -80,12 +79,6 @@ jobs:
${SD}/adhoc.sh make-labels ${{ inputs.set_label_prefix }} ${{ inputs.docker_image_1 }} ${{ inputs.docker_image_2 }}
cat adhoc-make-labels.out >> "$GITHUB_OUTPUT"

- name: Make Wildcard Regex
id: make-test-regex
run: |
${SD}/adhoc.sh make-test-regex "${{ inputs.test_class_list }}"
cat adhoc-make-test-regex.out >> "$GITHUB_OUTPUT"

- name: Scale Input Numbers
id: scale-nums
run: |
Expand Down Expand Up @@ -114,7 +107,7 @@ jobs:
docker_image: ${{ inputs.docker_image_1 }}
run_label: ${{ needs.setup-benchmark-system.outputs.set_label_1 }}
test_package: "io.deephaven.benchmark.tests.standard"
test_class_regex: "${{ needs.setup-benchmark-system.outputs.test_class_regex }}"
test_class_list: "${{ inputs.test_class_list }}"
test_iterations: ${{ needs.setup-benchmark-system.outputs.test_iterations }}
scale_row_count: ${{ needs.setup-benchmark-system.outputs.test_row_count }}
distribution: ${{ inputs.distribution }}
Expand All @@ -130,7 +123,7 @@ jobs:
docker_image: ${{ inputs.docker_image_2 }}
run_label: ${{ needs.setup-benchmark-system.outputs.set_label_2 }}
test_package: "io.deephaven.benchmark.tests.standard"
test_class_regex: "${{ needs.setup-benchmark-system.outputs.test_class_regex }}"
test_class_list: "${{ inputs.test_class_list }}"
test_iterations: ${{ needs.setup-benchmark-system.outputs.test_iterations }}
scale_row_count: ${{ needs.setup-benchmark-system.outputs.test_row_count }}
distribution: ${{ inputs.distribution }}
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/adhoc-exist-remote-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,13 @@ jobs:
setup-benchmark-system:
runs-on: ubuntu-22.04
outputs:
test_class_regex: "${{ steps.make-test-regex.outputs.TEST_CLASS_REGEX }}"
test_row_count: ${{ steps.scale-nums.outputs.TEST_ROW_COUNT }}
test_iterations: ${{ steps.scale-nums.outputs.TEST_ITERATIONS }}
env:
SD: .github/scripts

steps:
- uses: actions/checkout@v4
- name: Make Wildcard Regex
id: make-test-regex
run: |
${SD}/adhoc.sh make-test-regex "${{ inputs.test_class_list }}"
cat adhoc-make-test-regex.out >> "$GITHUB_OUTPUT"

- name: Scale Input Numbers
id: scale-nums
run: |
Expand All @@ -86,7 +79,7 @@ jobs:
docker_image: ${{ inputs.docker_image }}
run_label: ${{ inputs.run_label }}
test_package: ${{ inputs.test_package }}
test_class_regex: "${{ needs.setup-benchmark-system.outputs.test_class_regex }}"
test_class_list: "${{ inputs.test_class_list }}"
test_iterations: ${{ needs.setup-benchmark-system.outputs.test_iterations }}
scale_row_count: ${{ needs.setup-benchmark-system.outputs.test_row_count }}
distribution: ${{ inputs.distribution }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compare-remote-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
docker_image: ${{ inputs.docker_image }}
run_label: "<version>"
test_package: "io.deephaven.benchmark.tests.compare"
test_class_regex: "^(Test.*|.+[.$]Test.*|.*Tests?)$"
test_class_list: "*"
test_iterations: 5
scale_row_count: 70000000
distribution: random
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-remote-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
docker_image: edge
run_label: "<date>"
test_package: "io.deephaven.benchmark.tests.standard"
test_class_regex: "^(Test.*|.+[.$]Test.*|.*Tests?)$"
test_class_list: "*"
test_iterations: 5
scale_row_count: 10000000
distribution: random
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-remote-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
docker_image: ${{ inputs.docker_image }}
run_label: "<version>"
test_package: "io.deephaven.benchmark.tests.standard"
test_class_regex: "^(Test.*|.+[.$]Test.*|.*Tests?)$"
test_class_list: "*"
test_iterations: 5
scale_row_count: 10000000
distribution: random
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/remote-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:
test_package:
required: true
type: string
test_class_regex:
test_class_list:
required: true
type: string
test_iterations:
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
USER: ${{secrets.BENCHMARK_USER}}
RUN_TYPE: ${{inputs.run_type}}
TEST_PKG: ${{inputs.test_package}}
TEST_RGX: "${{inputs.test_class_regex}}"
TEST_CLS: "${{inputs.test_class_list}}"
ROW_CNT: ${{inputs.scale_row_count}}
DISTRIB: ${{inputs.distribution}}

Expand All @@ -129,7 +129,7 @@ jobs:

- name: Run Remote Benchmarks
run: |
${SD}/run-ssh-local.sh ${HOST} ${USER} ${SD} run-benchmarks-remote ${RUN_TYPE} "${TEST_PKG}" "${TEST_RGX}" ${ROW_CNT} ${DISTRIB} ${{ matrix.tag }}
${SD}/run-ssh-local.sh ${HOST} ${USER} ${SD} run-benchmarks-remote ${RUN_TYPE} "${TEST_PKG}" "'"${TEST_CLS}"'" ${ROW_CNT} ${DISTRIB} ${{ matrix.tag }}

report-benchmarks:
needs: run-benchmarks
Expand Down
Loading