fix: Address a number of liveness-related issues #6366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the UnderlyingTableMaintainer the underlying table itself
…Referent of a DelegatingLivenessReferent are held by the delegating implementation's getWeakReference() result
…nt order than the usual
…hat this is followed in all but one documented exceptional case
…eanup() for its own (idempotent) implementation
…ned by a RetainedReferenceTracker with enforceStrongReachability=true
…d QueryTableAjTest to avoid future issues. Remove a few redundant LivenessScopes in QueryTableAjTest.
…) from dropping enqueued references. Preserve reachability at time of enqueue when not done via cleanup.
rcaudy
added
bug
cpwright
previously approved these changes
Nov 12, 2024
nbauernfeind
previously approved these changes
Nov 13, 2024
…entations, not just LivenessScope
cpwright
approved these changes
Nov 13, 2024
Contributor
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#359 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a more complete fix for #3545
Each commit is intended to be reviewed independently, in order.