feat!: provide key columns as scalars (vs. vectors) to RollingFormula
#6375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Nov 16, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/UpdateByOperatorFactory.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/UpdateByOperatorFactory.java
Outdated
Show resolved
Hide resolved
.../engine/table/impl/updateby/rollingformulamulticolumn/RollingFormulaMultiColumnOperator.java
Outdated
Show resolved
Hide resolved
.../engine/table/impl/updateby/rollingformulamulticolumn/RollingFormulaMultiColumnOperator.java
Outdated
Show resolved
Hide resolved
.../engine/table/impl/updateby/rollingformulamulticolumn/RollingFormulaMultiColumnOperator.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Nov 18, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/ZeroKeyUpdateByManager.java
Outdated
Show resolved
Hide resolved
.../engine/table/impl/updateby/rollingformulamulticolumn/RollingFormulaMultiColumnOperator.java
Outdated
Show resolved
Hide resolved
.../engine/table/impl/updateby/rollingformulamulticolumn/RollingFormulaMultiColumnOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/UpdateByOperatorFactory.java
Outdated
Show resolved
Hide resolved
.../engine/table/impl/updateby/rollingformulamulticolumn/RollingFormulaMultiColumnOperator.java
Show resolved
Hide resolved
rcaudy
reviewed
Nov 19, 2024
Member
rcaudy
left a comment
rcaudy
left a comment
There was a problem hiding this comment.
Ready to approve, but for one comment in discussion.
rcaudy
approved these changes
Nov 19, 2024
Contributor
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#364 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
NOTE:
Symis a key column and is constant for each bucket. It is presented to the UDF as a string (not a vector).intCol/longColare vectors containing the window data.