-
Notifications
You must be signed in to change notification settings - Fork 90
chore: Remove Java 17 as prerequisite to build #7546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove Java 17 as prerequisite to build #7546
Conversation
This clarifies the usage of toolchain properties and removes Java 17 as a prerequisite for building. The nightly testing matrix still tests Java 17, and our language level for downstream consumers is unchanged.
No docs changes detected for fea64db |
.github/workflows/docs-ci.yml
Outdated
| - name: Checkout | ||
| uses: actions/checkout@v5 | ||
|
|
||
| # Note: web-client-api typedoc requires Java 17 (due to javadocs dependency) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not switch to a higher jdk for javadoc? or at least allow it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done as part of #7544, which now merged. I'll update this PR to account for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, sorry, I didnt make that connection.
This clarifies the usage of toolchain properties and (in combination with #7544) removes Java 17 as a prerequisite for builds. The nightly testing matrix still tests Java 17, and our language level for downstream consumers is unchanged.