Skip to content

Conversation

@devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Jan 6, 2026

This clarifies the usage of toolchain properties and (in combination with #7544) removes Java 17 as a prerequisite for builds. The nightly testing matrix still tests Java 17, and our language level for downstream consumers is unchanged.

This clarifies the usage of toolchain properties and removes Java 17 as a prerequisite for building. The nightly testing matrix still tests Java 17, and our language level for downstream consumers is unchanged.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

No docs changes detected for fea64db

@devinrsmith devinrsmith requested a review from niloc132 January 6, 2026 16:08
- name: Checkout
uses: actions/checkout@v5

# Note: web-client-api typedoc requires Java 17 (due to javadocs dependency)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not switch to a higher jdk for javadoc? or at least allow it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done as part of #7544, which now merged. I'll update this PR to account for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, sorry, I didnt make that connection.

@devinrsmith devinrsmith requested a review from niloc132 January 6, 2026 18:19
@devinrsmith devinrsmith merged commit 8f0504f into deephaven:main Jan 6, 2026
26 checks passed
@devinrsmith devinrsmith deleted the nightly/remove-17-as-general-req branch January 6, 2026 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants