Skip to content

Conversation

@lbooker42
Copy link
Contributor

@lbooker42 lbooker42 commented Jan 6, 2026

ReindexingFilters are treated as "serial", but the existing code did not handle barriers properly when a RIF was part of a list of filters. This was due to the independent execution of subsets of filters preceding or following the RIF.

This code tracks the encountered filter barriers and provides them to subsequent filter executions so the respected barrier requirements can be met during execution.

@lbooker42 lbooker42 requested a review from Copilot January 6, 2026 17:24
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

No docs changes detected for 052b956

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for barriers in reindexing filters by:

  • Adding a new ExtractReindexingFilters visitor class to identify reindexing filters within complex filter structures
  • Updating QueryTable.whereInternal() to properly track and propagate declared barriers when splitting filter execution around reindexing filters
  • Adding comprehensive test coverage for both sorted and unsorted clock filters with various barrier configurations

The key changes ensure that when filters are split for reindexing, barriers declared in earlier filters are properly propagated to later filters, maintaining correct execution ordering.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
ExtractReindexingFilters.java New visitor class that extracts reindexing filters from where filter hierarchies, unwrapping barrier and serial wrappers
QueryTable.java Refactored reindexing filter handling to track and propagate declared barriers across filter subsets; consolidated filter imports
TestClockFilters.java Added comprehensive test cases validating barrier behavior with sorted and unsorted clock filters in various configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant