Skip to content

ci: Change npm publishing to OIDC compatible node version #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattrunyon merged 1 commit into from
Jan 6, 2026
Merged

ci: Change npm publishing to OIDC compatible node version #7549

mattrunyon merged 1 commit into from
Jan 6, 2026
+2 −4

Conversation

@mattrunyon
Copy link
Contributor

@mattrunyon mattrunyon commented Jan 6, 2026 •
edited
Loading

I added the workflow to npm for this package to use OIDC. The CI job already has the id-token: write permission. AFAIK, npm publish just handles it automatically within GitHub Actions (with Node 24+/npm 11+). Docs here

image

@mattrunyon mattrunyon self-assigned this Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

No docs changes detected for 482858f

mofojed
mofojed approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Checked on npmjs as well and the publish-ci.yml workflow is added as the trusted publisher so we should be good there.

@mattrunyon mattrunyon enabled auto-merge (squash) January 6, 2026 22:10
@mattrunyon mattrunyon merged commit bd34c88 into deephaven:main Jan 6, 2026
26 of 28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
@mattrunyon mattrunyon deleted the fix-npm-publish branch January 6, 2026 22:42
@mattrunyon mattrunyon restored the fix-npm-publish branch January 6, 2026 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mofojed mofojed mofojed approved these changes

@devinrsmith devinrsmith Awaiting requested review from devinrsmith devinrsmith is a code owner

@jcferretti jcferretti Awaiting requested review from jcferretti jcferretti is a code owner

@JamesXNelson JamesXNelson Awaiting requested review from JamesXNelson JamesXNelson is a code owner

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@mattrunyon mattrunyon

Labels

NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattrunyon @mofojed