feat: DH-21579: add allow_string parameter to python instant_val#7644
Merged
devinrsmith merged 1 commit intodeephaven:mainfrom Feb 3, 2026
Merged
Conversation
This allows python to properly configure a JSON value as a JSON string that encodes a number of temporal units (seconds, millis, micros, nanos) since the epoch. For example, the JSON string with number of seconds since the epoch ```json "1770051098" ``` can now be represented in python by ```python instant_val(number_format="s", allow_string=True) ``` This functionality is already present on the Java side via a "lenient" `io.deephaven.json.InstantNumberValue`, which already allows JSON string types.
devinrsmith
requested review from
chipkent,
cpwright,
jmao-denver and
rcaudy
as code owners
Contributor
No docs changes detected for aeb9590 |
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows python to properly configure a JSON value as a JSON string that encodes a number of temporal units (seconds, millis, micros, nanos) since the epoch. For example, the JSON string with number of seconds since the epoch
"1770051098"can now be represented in python by
This functionality is already present on the Java side via a "lenient"
io.deephaven.json.InstantNumberValue, which already allows JSON string types.