fix(csharp/client): DH-21586: Increase MaxReceiveMessageSize to 100M#7647
Merged
kosak merged 1 commit intodeephaven:mainfrom Feb 4, 2026
Merged
Conversation
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
No docs changes detected for 94fd724 |
kosak
force-pushed
the
kosak_increase-grpc-receive-size
branch
from
5a28ec8 to
94fd724
Compare
kosak
changed the title
lbooker42
approved these changes
Feb 3, 2026
| var channelOptions = new GrpcChannelOptions(); | ||
| var channelOptions = new GrpcChannelOptions { | ||
| // Match outgoing size in io.deephaven.extensions.barrage.BarrageMessageWriterImpl | ||
| MaxReceiveMessageSize = 100 * 1024 * 1024 |
Contributor
There was a problem hiding this comment.
Not your fault, but would be better to have a shared constant (IMO).
Contributor
Author
There was a problem hiding this comment.
I feel the same way. We probably should do something nicer (maybe have the client request a max message size with the server). We will defer to a follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the writer side, in
io.deephaven.extensions.barrage.BarrageMessageWriterImpl, Barrage setsmaxOutboundMessageSizeto 100 * 1024 * 1024. We need to change the receive side to match.