docs: fix broken snapshots#7717
Merged
elijahpetty merged 2 commits intodeephaven:mainfrom Feb 25, 2026
Merged
Conversation
elijahpetty
added
documentation
Contributor
|
|
||
| denver_weather = function_generated_table( | ||
| table_generator=pull_denver_weather_data, source_tables=tt | ||
| table_generator=pull_denver_weather_data, |
Contributor
There was a problem hiding this comment.
do we definitely want to delete the time table? won't the table generator fail to work without a source table?
Contributor
Author
There was a problem hiding this comment.
I think it's okay to do so. The table we want is the denver_weather function generated table, which was only using tt as a trigger. Triggering denver_weather with the refresh_interval_ms param instead works.
margaretkennedy
previously approved these changes
Feb 24, 2026
margaretkennedy
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned up broken during the nightly checks.