-
Notifications
You must be signed in to change notification settings - Fork 16
feat: DH-19292 Add ui.table selection event #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
mofojed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - my only comment is if we should bother throwing if always_fetch_columns isn't provided as well.
| on_cell_double_press: CellPressCallback | None = None, | ||
| on_column_press: ColumnPressCallback | None = None, | ||
| on_column_double_press: ColumnPressCallback | None = None, | ||
| on_selection_change: SelectionChangeCallback | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should throw if on_selection_change is set and always_fetch_columns is not set. Right now it just returns empty data if you don't specify always_fetch_columns. Though I guess in theory that would still tell you want the size of the selection is, and maybe that's all the want to know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya I added it to the Python side. Throws immediately if not wrapped in a component. If in a component, it will propagate to the client as a render error so the user can see something in that case still.
Did spot a weird case where I ran working code followed by code that threw and the panel just disappeared. I'll investigate a bit more and file a ticket
|
ui docs preview (Available for 14 days) |
Tested with this code (mostly to test
Ctrl+awith a large table doesn't hang)I would not recommend sorting this table as it almost instantly OOM my 20GB DH instance