fix: DH-18073: ui.image convert bytes to str (#1167) #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jun 26, 2025
mofojed
commented
- Picking feat: DH-18073: Static image creation for dx #1167 back to deephaven.ui v0.29
- Without this being in the deephaven.ui release branch, the part converting bytes to a string were missing
- DH-18703 failed because though we updated the plotly-express plugin, we failed to update the deephaven.ui plugin as well
Fixes [DH-18703](https://deephaven.atlassian.net/browse/DH-18703) Adds static image creation through an API similar to [Plotly's to_image](https://plotly.github.io/plotly.py-docs/generated/plotly.io.to_image.html) as well as a `to_image_uri` that can be used directly with a `ui.html.img` [DH-18703]: https://deephaven.atlassian.net/browse/DH-18703?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
|
ui docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
mofojed
changed the title
jnumainville
approved these changes
Jun 26, 2025
- Kaleido just released v1.0.0 yesterday (June 19, 2025), which contains breaking changes and is only compatible with plotly>=6.1.1 - We use plotly <6.0.0 (until we finish updating to the latest) - Fix up our docs and setup.cfg to be more explicit about which version of kaleido to install.
|
ui docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
|
|
||
| Convert a `DeephavenFigure` to a static image using the `to_image_uri` method. | ||
| In order to use this feature, you need to have the `kaleido` package installed. | ||
| Either install will `all` extras or install `kaleido` separately. |
Contributor
There was a problem hiding this comment.
Suggested change
| Either install will `all` extras or install `kaleido` separately. | |
| Either install with `all` extras or install `kaleido` separately. |
| ## Theme Template | ||
|
|
||
| Customize the theme with the `template` argument. | ||
| Default options are `"plotly"`, `"plotly_white"`, `"plotly_dark"`, `"ggplot2"`, `"seaborn"`, and `"simple_white"`. |
Contributor
There was a problem hiding this comment.
might be nice to do -
"Default options are:
"plotly""plotly_white"
and so on
Member
Author
|
@margaretkennedy I probably should have removed you from this review - this is a cherry-pick back to a release branch... you already reviewed these docs when they went into main: #1167 Made a PR to main for your suggestions: #1200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.