Skip to content

feat: DH-18086: Envoy prefix#206

Merged
bmingles merged 6 commits intomainfrom
DH-18086-2_envoy-prefix
Jan 27, 2025
Merged

feat: DH-18086: Envoy prefix#206
bmingles merged 6 commits intomainfrom
DH-18086-2_envoy-prefix

Conversation

@bmingles
Copy link
Collaborator

@bmingles bmingles commented Jan 14, 2025

feat: DH-18086, DH-18085: Envoy prefix

Testing

Should be able to connect and run queries against the following:

  • Community server
  • non-envoy DHE server
  • Envoy DHE server

@bmingles bmingles marked this pull request as draft January 14, 2025 16:30
@bmingles bmingles force-pushed the DH-18086_grpc-transport branch from b8d6fcb to 0c5ce14 Compare January 16, 2025 17:18
@bmingles bmingles force-pushed the DH-18086-2_envoy-prefix branch from 1367723 to 68d276d Compare January 16, 2025 17:54
@bmingles bmingles force-pushed the DH-18086_grpc-transport branch from bc64340 to c8db2fc Compare January 21, 2025 17:19
Base automatically changed from DH-18086_grpc-transport to main January 21, 2025 18:21
@bmingles bmingles force-pushed the DH-18086-2_envoy-prefix branch from 68d276d to 9dee1bd Compare January 21, 2025 18:28
@bmingles bmingles changed the title DH-18086: Envoy prefix feat: DH-18086: Envoy prefix Jan 21, 2025
@github-actions
Copy link

github-actions bot commented Jan 21, 2025

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:00:35
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅2009
should return custom settings: Empty configspassed ✅519
should return custom settings: Populated configspassed ✅121
should be able to load VSCodepassed ✅909
should only be visible when a supported file type is active: test.groovypassed ✅2597
should only be visible when a supported file type is active: test.pypassed ✅941
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles force-pushed the DH-18086-2_envoy-prefix branch 2 times, most recently from 0c6fd83 to 558e043 Compare January 23, 2025 17:47
@bmingles bmingles changed the base branch from main to DH-18086-3_grpc-logging January 23, 2025 17:48
@bmingles bmingles force-pushed the DH-18086-2_envoy-prefix branch from 558e043 to fecc00a Compare January 23, 2025 18:17
Base automatically changed from DH-18086-3_grpc-logging to main January 27, 2025 17:00
@bmingles bmingles force-pushed the DH-18086-2_envoy-prefix branch from fecc00a to aed2d2a Compare January 27, 2025 17:02
@bmingles bmingles marked this pull request as ready for review January 27, 2025 17:03
@bmingles bmingles requested a review from mofojed January 27, 2025 17:03
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested with QA sanluis and DHC. Good work!

@bmingles bmingles merged commit bd59aa3 into main Jan 27, 2025
3 checks passed
@bmingles bmingles deleted the DH-18086-2_envoy-prefix branch January 27, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants