Skip to content

fix: DH-18424: Force websocket connections for 0.37.x+ Core servers#207

Merged
bmingles merged 4 commits intomainfrom
DH-18424_use-websockets-037
Jan 17, 2025
Merged

fix: DH-18424: Force websocket connections for 0.37.x+ Core servers#207
bmingles merged 4 commits intomainfrom
DH-18424_use-websockets-037

Conversation

@bmingles
Copy link
Collaborator

@bmingles bmingles commented Jan 15, 2025

DH-18424: Force websocket connections for 0.37.x+ Core servers

Testing
I tested the following scenarios on my Mac:

  • Grizzly with Core+ 0.37.x (can use dev-grizzly2)
  • San Luis with Core+ 0.37.x (can use dev-sanluis)
  • Community http
  • Community https (note -Dhttp.websockets=true needs to be set when starting the server)
    Example START_OPTS -Dhttp.port=444 -Dhttp.websockets=true -Dssl.identity.type=privatekey -Dssl.identity.certChainPath=/dev-certs/localhost.crt -Dssl.identity.privateKeyPath=/dev-certs/localhost.key. Also NODE_EXTRA_CA_CERTS needs to be set when using self signed SSL certs (see README).

NOTE: Would be good to test at least the first 2 items on Windows since the user originally had some Windows specific issues. I don't have a way to do this since my Windows machine does not have access to the VPN

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000004:55:01
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1666
should return custom settings: Empty configspassed ✅283
should return custom settings: Populated configspassed ✅104
should be able to load VSCodepassed ✅1087
should only be visible when a supported file type is active: test.groovypassed ✅2838
should only be visible when a supported file type is active: test.pypassed ✅1048
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles requested a review from mofojed January 15, 2025 20:14
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @dsmmcken may be the only one with Windows now (unless @mattrunyon still has a Windows machine with VPN. David recently installed linux).

@bmingles bmingles merged commit 4fd2604 into main Jan 17, 2025
5 checks passed
@bmingles bmingles deleted the DH-18424_use-websockets-037 branch January 17, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants