You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DH-18191:
VS Code now has a Http: Electron Fetch setting that will make use of Electron fetch instead of NodeJS http modules. This allows us to connect without using the custom gRPC transport and also allows the OS trust store to be the record of trust for SSL certs instead of having to set NODE_EXTRA_CA_CERTS.
This PR detects whether the flag is enabled and only uses the custom gRPC transport if needed. Presumably there could be user scenarios where enabling might break other extensions or cause undesirable side effects, so falling back to the gRPC transport still seems like a good idea.
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: Empty config
passed ✅
3
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: String config
passed ✅
1
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: No label
passed ✅
1
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: Full config
passed ✅
0
src/services/ConfigService.spec.ts: getEnterpriseServers > should return enterprise servers: Empty config
passed ✅
0
src/services/ConfigService.spec.ts: getEnterpriseServers > should return enterprise servers: String config
passed ✅
1
src/services/PollingService.spec.ts: pollUntilTrue > should resolve when poll function returns true
passed ✅
7
src/services/PollingService.spec.ts: pollUntilTrue > should cancel polling if timeout exceeded
passed ✅
2
src/services/PollingService.spec.ts: pollUntilTrue > should cancel polling if cancel explicitly called
passed ✅
0
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > should key data by value equality
passed ✅
2
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > entries > should provide value equality entries
passed ✅
1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > keys > should provide value equality keys
passed ✅
0
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > forEach > should pass value equality keys to callback: undefined
passed ✅
1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > forEach > should pass value equality keys to callback: {}
passed ✅
1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > values > should provide values
passed ✅
0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: {}
passed ✅
2
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: test
passed ✅
0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 999
passed ✅
1
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: true
passed ✅
0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: false
passed ✅
0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 2025-02-06T17:42:02.469Z
passed ✅
0
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: null
passed ✅
1
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: undefined
passed ✅
1
src/util/promiseUtils.spec.ts: waitFor > should return a Promise that resolves after a given timeout
passed ✅
4
src/util/promiseUtils.spec.ts: withResolvers > should return a promise that resolves when resolve function is called
passed ✅
2
src/util/promiseUtils.spec.ts: withResolvers > should return a promise that rejects when reject function is called
passed ✅
0
src/util/serverUtils.spec.ts: getInitialServerStates > should derive server states from config
passed ✅
4
src/util/serverUtils.spec.ts: getPipServerUrl > should return a localhost url based on given port
passed ✅
1
src/util/serverUtils.spec.ts: parsePort > should parse port from string
passed ✅
0
src/util/serverUtils.spec.ts: parsePort > should throw error when port is not a number
passed ✅
1
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, undefined
passed ✅
4
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, subDirectory
passed ✅
1
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, undefined
passed ✅
0
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, subDirectory
passed ✅
1
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp
passed ✅
1
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp/subDirectory
passed ✅
3
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp
passed ✅
0
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp/subDirectory
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:true, isInitialized:true
passed ✅
5
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:true, isInitialized:false
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:false, isInitialized:true
passed ✅
0
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:false, isInitialized:false
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:deephaven.plot.express.DeephavenFigure
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:deephaven.ui.Element
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Figure
passed ✅
0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:HierarchicalTable
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:OtherWidget
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:pandas.DataFrame
passed ✅
0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:PartitionedTable
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Table
passed ✅
0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:TableMap
passed ✅
1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Treemap
passed ✅
0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:TreeTable
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=true, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=true, isRunning=false
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=false, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=false, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=true, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=true, isRunning=false
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=false, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=false, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=true, label=some label
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=true, label=undefined
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=false, label=some label
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=false, label=undefined
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=true, label=some label
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=true, label=undefined
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=false, label=some label
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=false, label=undefined
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Managed, canStartServer=true
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Managed, canStartServer=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Running, canStartServer=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Running, canStartServer=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Managed, canStartServer=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Managed, canStartServer=false
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Running, canStartServer=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Running, canStartServer=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=true, isRunning=true
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=true, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=false, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=false, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=true, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=true, isRunning=false
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=false, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=false, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=true, isRunning=true
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=true, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=false, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=false, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=true, isRunning=true
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=true, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=false, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=false, isRunning=false
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=true, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=true, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=false, isRunning=true
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=false, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=true, isRunning=true
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=true, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=false, isRunning=true
passed ✅
1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=false, isRunning=false
passed ✅
0
src/util/treeViewUtils.spec.ts: getVariableIconPath > should return icon path for variableType
passed ✅
1
src/util/treeViewUtils.spec.ts: groupServers > should group servers by state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bmingles
force-pushed
the
DH-18191-3_electron-fetch
branch
from
DH-18191:
VS Code now has a
Http: Electron Fetchsetting that will make use of Electron fetch instead of NodeJS http modules. This allows us to connect without using the custom gRPC transport and also allows the OS trust store to be the record of trust for SSL certs instead of having to setNODE_EXTRA_CA_CERTS.This PR detects whether the flag is enabled and only uses the custom gRPC transport if needed. Presumably there could be user scenarios where enabling might break other extensions or cause undesirable side effects, so falling back to the gRPC transport still seems like a good idea.