feat: DH-18665: Persistent logging with environment info by bmingles · Pull Request #221 · deephaven/vscode-deephaven

bmingles · 2025-02-21T23:08:24Z

DH-18665: Persistent logging with environment info

Test Plan

Open command palette and run Deephaven: Download Logs
Save the file (default location is current workspace, but you can save elsewhere if you want)
Should open containing folder in OS
Extract the .zip file
Should contain Deephaven logs + exthost.log file

github-actions · 2025-02-21T23:10:14Z

End-to-end Test Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
6	6	0	0	0	0	0	05:01:52

A ctrf plugin

Detailed Test Results

Name	Status	ms
should default to the correct settings	passed ✅	1916
should return custom settings: Empty configs	passed ✅	409
should return custom settings: Populated configs	passed ✅	104
should be able to load VSCode	passed ✅	835
should only be visible when a supported file type is active: test.groovy	passed ✅	3166
should only be visible when a supported file type is active: test.py	passed ✅	1174

A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

github-actions · 2025-02-21T23:10:16Z

Unit Test Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
119	119	0	0	0	0	0	00:00:00

A ctrf plugin

Detailed Test Results

Name	Status	ms
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: Empty config	passed ✅	11
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: String config	passed ✅	5
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: No label	passed ✅	1
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: Full config	passed ✅	1
src/services/ConfigService.spec.ts: getEnterpriseServers > should return enterprise servers: Empty config	passed ✅	0
src/services/ConfigService.spec.ts: getEnterpriseServers > should return enterprise servers: String config	passed ✅	1
src/services/PollingService.spec.ts: pollUntilTrue > should resolve when poll function returns true	passed ✅	7
src/services/PollingService.spec.ts: pollUntilTrue > should cancel polling if timeout exceeded	passed ✅	2
src/services/PollingService.spec.ts: pollUntilTrue > should cancel polling if cancel explicitly called	passed ✅	1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > should key data by value equality	passed ✅	3
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > entries > should provide value equality entries	passed ✅	2
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > keys > should provide value equality keys	passed ✅	1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > forEach > should pass value equality keys to callback: undefined	passed ✅	3
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > forEach > should pass value equality keys to callback: {}	passed ✅	1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > values > should provide values	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: {}	passed ✅	2
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: test	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 999	passed ✅	1
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: true	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: false	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 2025-02-21T23:09:28.892Z	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: null	passed ✅	2
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: undefined	passed ✅	0
src/util/promiseUtils.spec.ts: waitFor > should return a Promise that resolves after a given timeout	passed ✅	4
src/util/promiseUtils.spec.ts: withResolvers > should return a promise that resolves when resolve function is called	passed ✅	2
src/util/promiseUtils.spec.ts: withResolvers > should return a promise that rejects when reject function is called	passed ✅	1
src/util/serverUtils.spec.ts: getInitialServerStates > should derive server states from config	passed ✅	6
src/util/serverUtils.spec.ts: getPipServerUrl > should return a localhost url based on given port	passed ✅	1
src/util/serverUtils.spec.ts: parsePort > should parse port from string	passed ✅	0
src/util/serverUtils.spec.ts: parsePort > should throw error when port is not a number	passed ✅	1
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, undefined	passed ✅	4
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, subDirectory	passed ✅	1
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, undefined	passed ✅	1
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, subDirectory	passed ✅	1
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp	passed ✅	1
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp/subDirectory	passed ✅	1
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp	passed ✅	0
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp/subDirectory	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:true, isInitialized:true	passed ✅	4
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:true, isInitialized:false	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:false, isInitialized:true	passed ✅	0
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:false, isInitialized:false	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:deephaven.plot.express.DeephavenFigure	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:deephaven.ui.Element	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Figure	passed ✅	0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:HierarchicalTable	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:OtherWidget	passed ✅	0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:pandas.DataFrame	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:PartitionedTable	passed ✅	0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Table	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:TableMap	passed ✅	0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Treemap	passed ✅	1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:TreeTable	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=true, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=true, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=false, isRunning=true	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=false, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=true, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=true, isRunning=false	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=false, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=false, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=true, label=some label	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=true, label=undefined	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=false, label=some label	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=false, label=undefined	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=true, label=some label	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=true, label=undefined	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=false, label=some label	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=false, label=undefined	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Managed, canStartServer=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Managed, canStartServer=false	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Running, canStartServer=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Running, canStartServer=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Managed, canStartServer=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Managed, canStartServer=false	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Running, canStartServer=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Running, canStartServer=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=true, isRunning=true	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=true, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=false, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=false, isRunning=false	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=true, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=true, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=false, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=false, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=true, isRunning=true	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=true, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=false, isRunning=true	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=false, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=true, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=true, isRunning=false	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=false, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=false, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=true, isRunning=true	passed ✅	2
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=true, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=false, isRunning=true	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=false, isRunning=false	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=true, isRunning=true	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=true, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=false, isRunning=true	passed ✅	1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=false, isRunning=false	passed ✅	0
src/util/treeViewUtils.spec.ts: getVariableIconPath > should return icon path for variableType	passed ✅	1
src/util/treeViewUtils.spec.ts: groupServers > should group servers by state	passed ✅	0
src/util/uiUtils.spec.ts: createConnectionOption > should return connection option: 'DHC', { label: 'python', url: URL{} }	passed ✅	3
src/util/uiUtils.spec.ts: createConnectionOption > should return connection option: 'DHC', { label: 'groovy', url: URL{} }	passed ✅	1
src/util/uiUtils.spec.ts: createConnectionQuickPickOptions > should return quick pick options: editorActiveConnectionUrl=No active	passed ✅	11
src/util/uiUtils.spec.ts: createConnectionQuickPickOptions > should return quick pick options: editorActiveConnectionUrl=Active A	passed ✅	1
src/util/uiUtils.spec.ts: createConnectionQuickPickOptions > should throw if no servers or connections	passed ✅	2
src/util/uiUtils.spec.ts: createConnectText > should return text and tooltip: 'connecting'	passed ✅	0
src/util/uiUtils.spec.ts: createConnectText > should return text and tooltip: 'connected'	passed ✅	1
src/util/uiUtils.spec.ts: createConnectText > should return text and tooltip: 'disconnected'	passed ✅	0
src/util/uiUtils.spec.ts: updateConnectionStatusBarItem > should update connection status bar item: 'connecting'	passed ✅	1
src/util/uiUtils.spec.ts: updateConnectionStatusBarItem > should update connection status bar item: 'connected'	passed ✅	0
src/util/uiUtils.spec.ts: updateConnectionStatusBarItem > should update connection status bar item: 'disconnected'	passed ✅	0
src/util/uiUtils.spec.ts: createSeparatorPickItem > should create a separator quick pick item with label	passed ✅	1
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://localhost:4000, localhost_4000	passed ✅	1
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://localhost:5000, localhost_5000	passed ✅	1
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://www.acme.com:6000, www_acme_com_6000	passed ✅	0
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://www.acme.com:7000, www_acme_com_7000	passed ✅	0

A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

mofojed

Looks good

bmingles added 3 commits February 21, 2025 13:24

Zipping log files (DH-18665)

8cda948

Add exthost.log to download and better env info log output (DH-18665)

8c3f011

More env info (DH-18665)

5fe381d

bmingles requested a review from mofojed February 21, 2025 23:23

bmingles marked this pull request as ready for review February 21, 2025 23:23

mofojed approved these changes Feb 24, 2025

View reviewed changes

bmingles merged commit 54ebd36 into main Feb 24, 2025
6 checks passed

bmingles deleted the DH-18665_output-info branch February 24, 2025 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: DH-18665: Persistent logging with environment info#221

feat: DH-18665: Persistent logging with environment info#221
bmingles merged 3 commits intomainfrom
DH-18665_output-info

bmingles commented Feb 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

mofojed left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bmingles commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Plan

Uh oh!

github-actions bot commented Feb 21, 2025

End-to-end Test Summary

Detailed Test Results

Failed Test Summary

Flaky Test Summary

Uh oh!

github-actions bot commented Feb 21, 2025

Unit Test Summary

Detailed Test Results

Failed Test Summary

Flaky Test Summary

Uh oh!

mofojed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bmingles commented Feb 21, 2025 •

edited

Loading