fix: DH-20899: Tree view command errors #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No docs changes detected for cd7234f |
End-to-end Test Summary
Failed Test SummaryNo failed tests ✨ |
Unit Test Summary
Failed Test SummaryNo failed tests ✨ |
mofojed
requested changes
Dec 12, 2025
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Do you have an issue filed in VS Code for why undefined is coming through? That seems like a bug...
I guess you'd be able to tell in the tree provider if a getTreeItem was called and returned undefined. It seems odd to have to add this protective check in every single context menu handler.
| serverState: ServerState | ||
| serverState: ServerState | undefined | ||
| ): Promise<void> => { | ||
| // Sometimes view/item/context commands pass undefined instead of a tree. |
Member
There was a problem hiding this comment.
This comment is strange. "instead of a tree. node." But it doesn't pass either of those?
Probably just say "instead of a value".
mofojed
previously approved these changes
Dec 15, 2025
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Would appreciate filing a bug for VS Code as well just for tracking.
Collaborator
Author
|
I filed microsoft/vscode#283655 and updated comments in this PR to reference it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DH-20899: Fixed some treeview command errors