Skip to content

Conversation

@bmingles
Copy link
Collaborator

@bmingles bmingles commented Dec 19, 2025

DH-21138:

  • Use gRPC transport with DHE client
  • I also slipped in a 1 line fix to the default value being used by the query creation UI. It stores the last selected language, but prefers the language of the active editor. In cases where no files are open, it was defaulting to undefined instead of using the last selection. This is fixed now

Testing

I tested connection scenarios:
For

  • grizzly envoy
  • grizzly non-envoy
  • gplus envoy
  • gplus non-envoy

I tested basic login, keypair gen and keypair login

Verified that the last language selected is remembered when no files are open and that if file is open, it's language is used as default for query creation dropdown

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

No docs changes detected for f7df6e9

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
330000014:00:39
A ctrf plugin

Failed Test Summary

No failed tests ✨

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Unit Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
2882880000000:00:00
A ctrf plugin

Failed Test Summary

No failed tests ✨

@bmingles bmingles requested a review from mofojed December 19, 2025 22:51
@bmingles bmingles merged commit 5ec26d5 into main Dec 22, 2025
10 of 11 checks passed
@bmingles bmingles deleted the DH-21138_grpc-transport-dhe branch December 22, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants