Skip to content

Conversation

@jnumainville
Copy link
Contributor

@jnumainville jnumainville commented May 30, 2025

This requires deephaven/deephaven-plugins#1185 for full support, but this is all that's needed to support linker directly with those changes.

@jnumainville jnumainville requested a review from mofojed May 30, 2025 20:41
@jnumainville jnumainville self-assigned this May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.21%. Comparing base (01f5930) to head (9fe5533).

Files with missing lines Patch % Lines
...s/dashboard-core-plugins/src/linker/LinkerUtils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2456      +/-   ##
==========================================
- Coverage   47.21%   47.21%   -0.01%     
==========================================
  Files         718      718              
  Lines       39620    39621       +1     
  Branches    10103     9915     -188     
==========================================
  Hits        18706    18706              
- Misses      20860    20904      +44     
+ Partials       54       11      -43     
Flag Coverage Δ
unit 47.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jnumainville jnumainville changed the title feat: Add dx linker support feat: DH-18840: Add dx linker support Jun 4, 2025
@jnumainville jnumainville marked this pull request as ready for review June 4, 2025 22:30
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattrunyon I presume your linker work will supersede these changes.

This isn't the pattern we want long-term but I'll allow it because it won't break anything, it's small, and the ongoing linker work should address it.

@mattrunyon
Copy link
Collaborator

Yes I'm removing link type/validity based on panel component and instead it's emitted by the corresponding component when selection occurs. So this will go away after my changes

@jnumainville jnumainville merged commit 5b34cd6 into deephaven:main Jun 6, 2025
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants