-
Notifications
You must be signed in to change notification settings - Fork 33
feat: Virtualize column organization lists #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Virtualize column organization lists #2568
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2568 +/- ##
==========================================
+ Coverage 44.54% 45.40% +0.86%
==========================================
Files 768 769 +1
Lines 43367 43511 +144
Branches 10973 11008 +35
==========================================
+ Hits 19317 19756 +439
+ Misses 24034 23739 -295
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is currently not working with the search modal |
|
Ok this is ready for review now The firefox e2e screenshot is the only one that changed. For some reason the virtualized scroll is measuring slightly different on firefox than chrome/webkit. Not sure why, but it's consistent and not a big deal/worth trying to adjust for just Firefox IMO. Didn't see any issues about it on the |
packages/iris-grid/src/sidebar/visibility-ordering-builder/sortable-tree/utilities.ts
Outdated
Show resolved
Hide resolved
packages/iris-grid/src/sidebar/visibility-ordering-builder/VisibilityOrderingBuilder.tsx
Outdated
Show resolved
Hide resolved
dsmmcken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, can't seem to break it anymore.

Fixes #1650
Further improvement for DH-18960 that wasn't part of the ticket, but will be appreciated. The original ticket was big enough I didn't want to add another feature to that PR.
Fixes the issue when dragging lots of columns the drag overlay grew. It is now properly truncating. Also removed the drag handle icon from the drag overlay just to give a bit more room when dragging groups (and I think the handle doesn't make that much sense to show when you're already dragging)
Also fixed the drop animation when dragging from/to a group. Same issue as the general
movedColumnsfixed in the first PR.