Skip to content

Conversation

@mattrunyon
Copy link
Collaborator

Fixes #1650

Further improvement for DH-18960 that wasn't part of the ticket, but will be appreciated. The original ticket was big enough I didn't want to add another feature to that PR.

Fixes the issue when dragging lots of columns the drag overlay grew. It is now properly truncating. Also removed the drag handle icon from the drag overlay just to give a bit more room when dragging groups (and I think the handle doesn't make that much sense to show when you're already dragging)

Also fixed the drop animation when dragging from/to a group. Same issue as the general movedColumns fixed in the first PR.

@mattrunyon mattrunyon requested review from a team and dsmmcken November 8, 2025 00:02
@mattrunyon mattrunyon self-assigned this Nov 8, 2025
@mattrunyon mattrunyon requested review from vbabich and removed request for a team November 8, 2025 00:02
@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 86.46617% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.40%. Comparing base (e1c2dc4) to head (99b9a2d).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...g-builder/sortable-tree/SortableTreeDndContext.tsx 21.42% 11 Missing ⚠️
...ty-ordering-builder/sortable-tree/SortableTree.tsx 84.61% 4 Missing ⚠️
...ity-ordering-builder/VisibilityOrderingBuilder.tsx 94.82% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
+ Coverage   44.54%   45.40%   +0.86%     
==========================================
  Files         768      769       +1     
  Lines       43367    43511     +144     
  Branches    10973    11008      +35     
==========================================
+ Hits        19317    19756     +439     
+ Misses      24034    23739     -295     
  Partials       16       16              
Flag Coverage Δ
unit 45.40% <86.46%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattrunyon
Copy link
Collaborator Author

This is currently not working with the search modal

@mattrunyon
Copy link
Collaborator Author

Ok this is ready for review now

The firefox e2e screenshot is the only one that changed. For some reason the virtualized scroll is measuring slightly different on firefox than chrome/webkit. Not sure why, but it's consistent and not a big deal/worth trying to adjust for just Firefox IMO. Didn't see any issues about it on the @tanstack/query repo

@dsmmcken
Copy link
Contributor

drag_after

Had a list, dragged a bunch of stuff around, made a group, dragged the stuff in an out of a group. Was generally just bashing on it and it is doing this ^

@mattrunyon mattrunyon requested a review from vbabich November 13, 2025 20:44
vbabich
vbabich previously approved these changes Nov 13, 2025
dsmmcken
dsmmcken previously approved these changes Nov 13, 2025
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, can't seem to break it anymore.

@mattrunyon mattrunyon dismissed stale reviews from dsmmcken and vbabich via 27528bd November 13, 2025 22:50
@mattrunyon mattrunyon merged commit 089eabd into deephaven:main Nov 14, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor column drag performance with table sidebar open

3 participants