-
Notifications
You must be signed in to change notification settings - Fork 33
fix: rollup rows dropzone area in table sidebar #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the dropzone area behavior in the rollup rows table sidebar by improving how the drop target height is calculated and displayed during drag-and-drop operations.
Key Changes:
- Replaced dynamic JavaScript-based height calculation with CSS custom properties for more reliable dropzone sizing
- Added
hasPlaceholderprop toDraggableItemListto conditionally render drag-and-drop placeholders - Enhanced visual feedback with background color changes when dragging over drop zones
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/iris-grid/src/sidebar/RollupRows.tsx | Removed conditional height calculation logic and passes CSS custom properties for height management; added hasPlaceholder prop to enable placeholder rendering |
| packages/iris-grid/src/sidebar/RollupRows.scss | Implemented CSS custom property-based height calculation with min-height, added visual feedback for drag-over states, and improved text wrapping |
| packages/components/src/DraggableItemList.tsx | Added optional hasPlaceholder prop with default value false to conditionally render the droppable placeholder element |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
+ Coverage 44.54% 45.17% +0.62%
==========================================
Files 768 769 +1
Lines 43367 43462 +95
Branches 10973 11170 +197
==========================================
+ Hits 19317 19632 +315
+ Misses 24034 23784 -250
- Partials 16 46 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]>
Previous behaviour would grow the drop-zone when an item is picked up, but that expanded area would not actually be droppable. Leading to frustrating ux where it seemed like you dropped an item in the droppable area, but it would revert. The list needs to grow, so that you can place the item above or below any existing items.

Root cause is DnD doesn't treat that area as droppable unless it is overlapping the list. This change enables the DnD placeholder item, to fill out the expanded area. The list now grows after initial contact rather than before, as that's when the placeholder gets added by DnD.
Additionally, added a hover styling to positively show your drop is going to be successful. Ultimately though, this goes away entirely with pivot builder.