Skip to content

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Nov 21, 2025

  • Decouple IrisGrid from Dh.Sort, delegate sort hydration to model to allow plugins use own sort API
  • Allow negative column indexes in IrisGrid, so plugins could sort and filter on non-columns, such as ColumnBy sources

@vbabich vbabich changed the title Use SortDescriptor instead of Dh.Sort in IrisGrid refactor: Use SortDescriptor instead of Dh.Sort in IrisGrid Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.44%. Comparing base (a467feb) to head (b9dc108).

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGridUtils.ts 82.60% 4 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 33.33% 2 Missing ⚠️
packages/iris-grid/src/IrisGridTestUtils.ts 60.00% 2 Missing ⚠️
packages/iris-grid/src/IrisGridRenderer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/v0.85    #2580      +/-   ##
=================================================
- Coverage          48.45%   48.44%   -0.01%     
=================================================
  Files                712      712              
  Lines              39736    39747      +11     
  Branches            9920     9921       +1     
=================================================
+ Hits               19253    19255       +2     
- Misses             20470    20479       +9     
  Partials              13       13              
Flag Coverage Δ
unit 48.44% <82.35%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich changed the title refactor: Use SortDescriptor instead of Dh.Sort in IrisGrid refactor: Decouple IrisGrid from Dh.Sort, use SortDescriptor instead Nov 24, 2025
@vbabich vbabich force-pushed the sort-descriptors-v0.85 branch from 8469de4 to 42c12cc Compare November 24, 2025 21:29
@vbabich vbabich force-pushed the sort-descriptors-v0.85 branch from 42c12cc to bb284db Compare November 25, 2025 03:56
…eephaven#2583)

- Decouple IrisGrid from Dh.Sort, delegate sort hydration to model to
allow plugins use own sort API
- Allow negative column indexes in IrisGrid, so plugins could sort and
filter on non-columns, such as ColumnBy sources
@vbabich vbabich changed the title refactor: Decouple IrisGrid from Dh.Sort, use SortDescriptor instead refactor: Cherry-pick #2583 Decouple IrisGrid from Dh.Sort, use SortDescriptor instead Nov 25, 2025
@vbabich vbabich self-assigned this Nov 25, 2025
@vbabich vbabich marked this pull request as ready for review November 25, 2025 21:43
@vbabich vbabich requested a review from mofojed November 25, 2025 21:57
@mofojed mofojed enabled auto-merge (squash) November 26, 2025 15:24
@mofojed mofojed merged commit c82ffb4 into deephaven:release/v0.85 Nov 26, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants