Skip to content

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Nov 25, 2025

  • Decouple IrisGrid from Dh.Sort, delegate sort hydration to model to allow plugins use own sort API
  • Allow negative column indexes in IrisGrid, so plugins could sort and filter on non-columns, such as ColumnBy sources

@vbabich vbabich self-assigned this Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.48%. Comparing base (89dc832) to head (21de3f2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGridUtils.ts 82.60% 4 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 33.33% 2 Missing ⚠️
packages/iris-grid/src/IrisGridTestUtils.ts 60.00% 2 Missing ⚠️
packages/iris-grid/src/IrisGridRenderer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   45.49%   45.48%   -0.01%     
==========================================
  Files         771      771              
  Lines       43580    43591      +11     
  Branches    11026    11211     +185     
==========================================
+ Hits        19825    19826       +1     
+ Misses      23739    23719      -20     
- Partials       16       46      +30     
Flag Coverage Δ
unit 45.48% <82.35%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich marked this pull request as ready for review November 25, 2025 16:00
@vbabich vbabich requested a review from mofojed November 25, 2025 16:00
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the removed JS doc, looks good otherwise. Glad it's not a breaking change either!

@vbabich vbabich requested a review from mofojed November 25, 2025 20:00
@vbabich vbabich requested a review from mofojed November 25, 2025 21:23
@mofojed mofojed enabled auto-merge (squash) November 25, 2025 21:30
@mofojed mofojed merged commit 2452a84 into deephaven:main Nov 25, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants