-
Notifications
You must be signed in to change notification settings - Fork 33
refactor: Decouple IrisGrid from Dh.Sort, use SortDescriptor instead #2583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vbabich
commented
Nov 25, 2025
- Decouple IrisGrid from Dh.Sort, delegate sort hydration to model to allow plugins use own sort API
- Allow negative column indexes in IrisGrid, so plugins could sort and filter on non-columns, such as ColumnBy sources
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
- Coverage 45.49% 45.48% -0.01%
==========================================
Files 771 771
Lines 43580 43591 +11
Branches 11026 11211 +185
==========================================
+ Hits 19825 19826 +1
+ Misses 23739 23719 -20
- Partials 16 46 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mofojed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about the removed JS doc, looks good otherwise. Glad it's not a breaking change either!