Skip to content

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Dec 2, 2025

  • Pre/post install scripts was something Sha1-hulud used to propagate
  • Just disable them
  • Updated scripts to ensure npm install then npm start/npm run build/npm run test all work correctly

- Still need to clean up the package scripts so we don't need that for our start/build steps
@mofojed mofojed requested review from a team and bmingles and removed request for a team December 2, 2025 17:59
@mofojed mofojed self-assigned this Dec 2, 2025
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of simplification suggestions

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.22%. Comparing base (51c0a51) to head (b907175).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2586      +/-   ##
==========================================
- Coverage   45.48%   45.22%   -0.26%     
==========================================
  Files         771      771              
  Lines       43591    43591              
  Branches    11211    11027     -184     
==========================================
- Hits        19827    19716     -111     
- Misses      23748    23859     +111     
  Partials       16       16              
Flag Coverage Δ
unit 45.22% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed requested a review from bmingles December 3, 2025 14:56
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mofojed mofojed merged commit 5b562b7 into deephaven:main Dec 3, 2025
10 of 11 checks passed
@mofojed mofojed deleted the DH-21044-npm-hardening branch December 3, 2025 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants