-
Notifications
You must be signed in to change notification settings - Fork 103
[Aikido] Fix 6 security issues in jinja2, sphinx #1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: linux-6.6.y
Are you sure you want to change the base?
[Aikido] Fix 6 security issues in jinja2, sphinx #1338
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @aikido-autofix[bot]. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
|
It doesn’t look very important, but we shouldn’t close this PR — it will pop up again later. That said, we also shouldn’t merge the commit as-is because its commit message doesn’t comply with the kernel’s commit guidelines. This issue appears to exist in upstream mainline as well; you can submit an upstream patch and backport it at an appropriate time. |
|
/ok-to-test |
deepin pr auto review我来对这个git diff进行审查:
改进建议:
# jinja2>=3.1 is not compatible with Sphinx<4.0
jinja2<3.1
Sphinx==2.4.5或者如果确实需要jinja2 3.1.6,那么应该: # jinja2>=3.1 requires Sphinx>=4.0
jinja2==3.1.6
Sphinx>=4.0
# jinja2>=3.1 is not compatible with Sphinx<4.0
# Using jinja2<3.1 to maintain compatibility with Sphinx 2.4.5
jinja2<3.1
Sphinx==2.4.5
# jinja2>=3.1 is not compatible with Sphinx<4.0
jinja2>=3.0,<3.1
Sphinx==2.4.5这些修改将使依赖关系更加清晰和可预测,避免潜在的安装和运行时问题。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to address 6 security vulnerabilities (CVEs) in jinja2 and sphinx by upgrading these packages. The changes modify the Python package requirements file used for building Sphinx documentation. However, the PR contains a critical bug that will prevent the dependencies from being installed correctly.
Key Changes
- Upgrades Sphinx from version 2.4.4 to 2.4.5
- Attempts to add jinja2 version 3.1.6 to fix multiple high and medium severity CVEs
- Introduces conflicting version constraints that will cause dependency resolution to fail
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Upgrading jinja2, sphinx to address vulnerabilities.
6 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
xmlattrfilter can be abused ...str.formatpossible by storing a reference to the format method of a malicious string and invoking it indirectly through a filter. This flaw allows an attac...xmlattrfilter in affected versions of Jinja accepts keys containing non-attribute characters. XML/HTML attributes cannot contain spaces,/,>, or=, as each would then be interpreted as starting a separate attribute. If an application accepts ke...