-
Notifications
You must be signed in to change notification settings - Fork 108
drm: Add SMI drm graphic driver #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Teddy Wang <[email protected]>
|
Hi @teddywlq. Thanks for your PR. 😃 |
|
Hi @teddywlq. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We failed to fetch the diff for pull request #968
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive DRM driver for SiliconMotion graphics chips (SM750/SM768/SM770) including display controller functions, 2D acceleration, and hardware management.
- Implements DDK768 hardware abstraction layer with display control, power management, 2D graphics engine support
- Provides cursor control, clock configuration, and chip initialization functionality
- Includes VDIF timing structures for display mode support
Reviewed Changes
Copilot reviewed 52 out of 190 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/gpu/drm/smidrm/ddk768/ddk768_display.c | Core display control functions for DDK768 including DPMS, timing, and panel control |
| drivers/gpu/drm/smidrm/ddk768/ddk768_cursor.* | Hardware cursor management implementation |
| drivers/gpu/drm/smidrm/ddk768/ddk768_clock.* | PLL clock calculation and programming functions |
| drivers/gpu/drm/smidrm/ddk768/ddk768_chip.* | Chip detection, initialization, and memory configuration |
| drivers/gpu/drm/smidrm/ddk768/ddk768_2d.* | 2D graphics acceleration engine implementation |
| drivers/gpu/drm/smidrm/ddk768/ddk768.h | Main header file consolidating DDK768 modules |
| drivers/gpu/drm/smidrm/ddk750/vdif.h | Video display timing format definitions |
Comments suppressed due to low confidence (2)
drivers/gpu/drm/smidrm/ddk768/ddk768_display.c:16
- Function 'ddk768_calcPLL' was made static in ddk768_clock.c but it's being used as a global function. This appears to be an inconsistency between .c and .c.bak files
/*
drivers/gpu/drm/smidrm/ddk768/ddk768_cursor.h:43
- Header guard mismatch: the comment says 'CURSOR_H' but the actual guard is 'DDK768_CURSOR_H'
#endif /* _CURSOR_H_ */
| * It returns a double word with the transparent fields properly set, | ||
| * while other fields are 0. | ||
| */ | ||
| static unsigned long ddk768_deGetTransparency(void) |
Copilot
AI
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function 'ddk768_deGetTransparency' was made static but it's used throughout the file. This indicates it should either be exposed as a public API or remain static as helper function
| static unsigned long ddk768_deGetTransparency(void) | |
| unsigned long ddk768_deGetTransparency(void) |
| /* | ||
| * This function sets the pixel format that will apply to the 2D Engine. | ||
| */ | ||
| static void ddk768_deSetPixelFormat( |
Copilot
AI
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function 'ddk768_deSetPixelFormat' was made static but used multiple times throughout the file. Consider if this should be part of the public API
| static void ddk768_deSetPixelFormat( | |
| void ddk768_deSetPixelFormat( |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Add SM750/SM768/SM770 DRM driver for SiliconMotopm graphic chips.