Skip to content

Conversation

@teddywlq
Copy link
Contributor

Add SM750/SM768/SM770 DRM driver for SiliconMotopm graphic chips.

@deepin-ci-robot
Copy link

Hi @teddywlq. Thanks for your PR. 😃

@deepin-ci-robot
Copy link

Hi @teddywlq. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign opsiff for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We failed to fetch the diff for pull request #968

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive DRM driver for SiliconMotion graphics chips (SM750/SM768/SM770) including display controller functions, 2D acceleration, and hardware management.

  • Implements DDK768 hardware abstraction layer with display control, power management, 2D graphics engine support
  • Provides cursor control, clock configuration, and chip initialization functionality
  • Includes VDIF timing structures for display mode support

Reviewed Changes

Copilot reviewed 52 out of 190 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
drivers/gpu/drm/smidrm/ddk768/ddk768_display.c Core display control functions for DDK768 including DPMS, timing, and panel control
drivers/gpu/drm/smidrm/ddk768/ddk768_cursor.* Hardware cursor management implementation
drivers/gpu/drm/smidrm/ddk768/ddk768_clock.* PLL clock calculation and programming functions
drivers/gpu/drm/smidrm/ddk768/ddk768_chip.* Chip detection, initialization, and memory configuration
drivers/gpu/drm/smidrm/ddk768/ddk768_2d.* 2D graphics acceleration engine implementation
drivers/gpu/drm/smidrm/ddk768/ddk768.h Main header file consolidating DDK768 modules
drivers/gpu/drm/smidrm/ddk750/vdif.h Video display timing format definitions
Comments suppressed due to low confidence (2)

drivers/gpu/drm/smidrm/ddk768/ddk768_display.c:16

  • Function 'ddk768_calcPLL' was made static in ddk768_clock.c but it's being used as a global function. This appears to be an inconsistency between .c and .c.bak files
/*

drivers/gpu/drm/smidrm/ddk768/ddk768_cursor.h:43

  • Header guard mismatch: the comment says 'CURSOR_H' but the actual guard is 'DDK768_CURSOR_H'
#endif /* _CURSOR_H_ */

* It returns a double word with the transparent fields properly set,
* while other fields are 0.
*/
static unsigned long ddk768_deGetTransparency(void)
Copy link

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function 'ddk768_deGetTransparency' was made static but it's used throughout the file. This indicates it should either be exposed as a public API or remain static as helper function

Suggested change
static unsigned long ddk768_deGetTransparency(void)
unsigned long ddk768_deGetTransparency(void)

Copilot uses AI. Check for mistakes.
/*
* This function sets the pixel format that will apply to the 2D Engine.
*/
static void ddk768_deSetPixelFormat(
Copy link

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function 'ddk768_deSetPixelFormat' was made static but used multiple times throughout the file. Consider if this should be part of the public API

Suggested change
static void ddk768_deSetPixelFormat(
void ddk768_deSetPixelFormat(

Copilot uses AI. Check for mistakes.
@teddywlq teddywlq closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants