Skip to content

[python]remove keys to check param dict#2677

Merged
sindhuvahinis merged 1 commit intodeepjavalibrary:masterfrom
sindhuvahinis:remkeys
Jan 24, 2025
Merged

[python]remove keys to check param dict#2677
sindhuvahinis merged 1 commit intodeepjavalibrary:masterfrom
sindhuvahinis:remkeys

Conversation

@sindhuvahinis
Copy link
Copy Markdown
Contributor

Description

#2676 -> Removing .keys() reference in other handlers, since it is redundant.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@sindhuvahinis sindhuvahinis requested review from a team and zachgk as code owners January 24, 2025 00:10
@sindhuvahinis sindhuvahinis merged commit 6b29181 into deepjavalibrary:master Jan 24, 2025
@sindhuvahinis sindhuvahinis deleted the remkeys branch January 24, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants