Skip to content

[python] Support NxDI with Vllm#2686

Merged
sindhuvahinis merged 2 commits intodeepjavalibrary:masterfrom
sindhuvahinis:vllmnxdi
Jan 27, 2025
Merged

[python] Support NxDI with Vllm#2686
sindhuvahinis merged 2 commits intodeepjavalibrary:masterfrom
sindhuvahinis:vllmnxdi

Conversation

@sindhuvahinis
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@sindhuvahinis sindhuvahinis requested review from a team and zachgk as code owners January 24, 2025 23:31
device: Optional[str] = None
preloaded_model: Optional[Any] = None
generation_config: Optional[Any] = None
override_neuron_config: Optional[Dict] = None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddvenk This one is not needed, if your pass through PR gets merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, let's get this one merged first and then I can fixup the passthrough pr and test it with the nxdi changes here

@siddvenk
Copy link
Contributor

We spoke offline about this earlier - in a subsequent change we'll be adding

  • more tests
  • doc updates

@sindhuvahinis
Copy link
Contributor Author

We spoke offline about this earlier - in a subsequent change we'll be adding

* more tests

* doc updates

Yes, I am testing AOT for NxDI and speculative decoding. Once they are done, we could add doc updates as well.

@sindhuvahinis sindhuvahinis merged commit a1d2ea3 into deepjavalibrary:master Jan 27, 2025
8 of 9 checks passed
@sindhuvahinis sindhuvahinis deleted the vllmnxdi branch February 3, 2025 16:29
sindhuvahinis added a commit to sindhuvahinis/djl-serving that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants