[python] Support NxDI with Vllm#2686
Merged
sindhuvahinis merged 2 commits intodeepjavalibrary:masterfrom Jan 27, 2025
Merged
Conversation
sindhuvahinis
commented
Jan 24, 2025
| device: Optional[str] = None | ||
| preloaded_model: Optional[Any] = None | ||
| generation_config: Optional[Any] = None | ||
| override_neuron_config: Optional[Dict] = None |
Contributor
Author
There was a problem hiding this comment.
@siddvenk This one is not needed, if your pass through PR gets merged.
Contributor
There was a problem hiding this comment.
Good to know, let's get this one merged first and then I can fixup the passthrough pr and test it with the nxdi changes here
667fe3d to
db81cb1
Compare
db81cb1 to
98eff58
Compare
Contributor
|
We spoke offline about this earlier - in a subsequent change we'll be adding
|
siddvenk
approved these changes
Jan 27, 2025
Contributor
Author
Yes, I am testing AOT for NxDI and speculative decoding. Once they are done, we could add doc updates as well. |
sindhuvahinis
added a commit
to sindhuvahinis/djl-serving
that referenced
this pull request
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B