Skip to content

[docker] separate vllm and lmi-dist modes into separate virtual envir…#2690

Merged
siddvenk merged 1 commit intodeepjavalibrary:masterfrom
siddvenk:vllm-070-upgrade
Jan 31, 2025
Merged

[docker] separate vllm and lmi-dist modes into separate virtual envir…#2690
siddvenk merged 1 commit intodeepjavalibrary:masterfrom
siddvenk:vllm-070-upgrade

Conversation

@siddvenk
Copy link
Contributor

…onments

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@siddvenk siddvenk force-pushed the vllm-070-upgrade branch 4 times, most recently from 180ba27 to fce9fb8 Compare January 28, 2025 18:50
@siddvenk siddvenk marked this pull request as ready for review January 29, 2025 16:17
@siddvenk siddvenk requested review from a team and zachgk as code owners January 29, 2025 16:17
base_directory=$1
requirements_file=$2

virtual_env_path="${base_directory}/venv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for the "/venv" suffix? This makes the name of all virtual envs created with this script "venv". I noticed when activating it in a shell, since it shows the name in parens in the prompt and it was "(venv) ...".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea i don't think this is actually needed - can remove venv.

I also don't need to source/deactivate - can just call the pip from /bin/pip

@siddvenk siddvenk force-pushed the vllm-070-upgrade branch 2 times, most recently from 20a6bc3 to d0c0e90 Compare January 30, 2025 21:53
@siddvenk siddvenk force-pushed the vllm-070-upgrade branch 2 times, most recently from 9eed597 to 7795afb Compare January 31, 2025 21:08
@siddvenk siddvenk merged commit dc08153 into deepjavalibrary:master Jan 31, 2025
9 checks passed
@siddvenk siddvenk deleted the vllm-070-upgrade branch April 18, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants