[docker] separate vllm and lmi-dist modes into separate virtual envir…#2690
Merged
siddvenk merged 1 commit intodeepjavalibrary:masterfrom Jan 31, 2025
Merged
Conversation
180ba27 to
fce9fb8
Compare
xyang16
reviewed
Jan 29, 2025
| base_directory=$1 | ||
| requirements_file=$2 | ||
|
|
||
| virtual_env_path="${base_directory}/venv" |
Contributor
There was a problem hiding this comment.
Any particular reason for the "/venv" suffix? This makes the name of all virtual envs created with this script "venv". I noticed when activating it in a shell, since it shows the name in parens in the prompt and it was "(venv) ...".
Contributor
Author
There was a problem hiding this comment.
yea i don't think this is actually needed - can remove venv.
I also don't need to source/deactivate - can just call the pip from /bin/pip
20a6bc3 to
d0c0e90
Compare
12 tasks
xyang16
approved these changes
Jan 31, 2025
9eed597 to
7795afb
Compare
…tual environments
7795afb to
a24ad1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onments
Description
Brief description of what this PR is about
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B