AutoFP8 to llmcompressor migration for FP8 quantization#2701
Merged
siddvenk merged 1 commit intodeepjavalibrary:masterfrom Feb 2, 2025
Merged
AutoFP8 to llmcompressor migration for FP8 quantization#2701siddvenk merged 1 commit intodeepjavalibrary:masterfrom
siddvenk merged 1 commit intodeepjavalibrary:masterfrom
Conversation
siddvenk
reviewed
Feb 1, 2025
siddvenk
reviewed
Feb 1, 2025
| "will not include this field.") | ||
|
|
||
| if output_properties.get("option.quantize") == "fp8": | ||
| output_properties["option.quantize"] = "compressed-tensors" |
Contributor
There was a problem hiding this comment.
does this work for both lmi-dist (vllm 0.6.3.post1) and vanilla vllm (0.7.0)?
siddvenk
approved these changes
Feb 2, 2025
Contributor
|
merging this for now - lgtm. let's validate this again with the vllm update for both lmi-dist/vllm |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates existing FP8 quantization functionality to llmcompressor from AutoFP8. The existing quantization recipe is fp8 weights and activation quantization, with static activation scales. Uses cnn-dailymail for calibration, defaulting to 512 samples at 2048 seq len.
Installed the previous version of llm-compressor (0.3.1) due to an issue with compatibility between llm-compressor (0.4.0) and transformers 2.5.2, which is the current version in djl-serving.
TODOs
Type of change
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"Feature/Issue validation/testing