Skip to content

[ci] fix correctness testing for neuronx#2704

Merged
siddvenk merged 1 commit intodeepjavalibrary:masterfrom
sindhuvahinis:correctnessneuron
Feb 3, 2025
Merged

[ci] fix correctness testing for neuronx#2704
siddvenk merged 1 commit intodeepjavalibrary:masterfrom
sindhuvahinis:correctnessneuron

Conversation

@sindhuvahinis
Copy link
Contributor

Description

Fixing Correctness Testing for neuron. Verified in my inf2 machine.

  • TP Degree for inf2 can be either 1 , 2, 4, 8, 24. Not sure, how tp degree 12 was working.
  • Changed the model to latest smaller model - llama 3.2 1B

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@sindhuvahinis sindhuvahinis requested review from a team and zachgk as code owners February 3, 2025 03:36
@siddvenk siddvenk merged commit b5e4ee9 into deepjavalibrary:master Feb 3, 2025
9 checks passed
@sindhuvahinis sindhuvahinis deleted the correctnessneuron branch February 3, 2025 16:28
sindhuvahinis added a commit to sindhuvahinis/djl-serving that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants