Closed
Conversation
ksuma2109
changed the title
xyang16
reviewed
Oct 31, 2025
| ) | ||
| options = vllm_model_list[model] | ||
| options["engine"] = "Python" | ||
| options["option.rolling_batch"] = "vllm" |
xyang16
reviewed
Oct 31, 2025
| @pytest.mark.gpu_4 | ||
| class TestGPTOSS: | ||
|
|
||
| def test_lora_llama3_8b(self): |
Contributor
There was a problem hiding this comment.
This is not gpt-oss model
xyang16
reviewed
Oct 31, 2025
| r.launch() | ||
| client.run("vllm_adapters phi2-unmerged-lora".split()) | ||
|
|
||
| def test_llama_68m_speculative_eagle(self): |
Contributor
There was a problem hiding this comment.
This is not gpt-oss model
xyang16
reviewed
Oct 31, 2025
| @pytest.mark.gpt_oss | ||
| @pytest.mark.lora | ||
| @pytest.mark.gpu_4 | ||
| class TestGPTOSS: |
Contributor
There was a problem hiding this comment.
We can test this gpt-oss model https://huggingface.co/openai/gpt-oss-20b
Contributor
Author
|
Closing this as I created a PR on wrong branch. @xyang16 The other branch has the relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestVllm1" -m "vllm"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B