Conversation
Lokiiiiii
commented
Nov 17, 2025
| @@ -0,0 +1,229 @@ | |||
| #!/usr/bin/env python | |||
Member
Author
There was a problem hiding this comment.
This file is a just a refactor of the adapter code that was in async_utilts before.
ksuma2109
approved these changes
Nov 19, 2025
ksuma2109
approved these changes
Nov 22, 2025
Contributor
ksuma2109
left a comment
There was a problem hiding this comment.
Custom Formatter specific code LGTM
xyang16
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Customers are consolidating their model deployments utilizing Multi-Lora to enhance efficiency through multi-tenancy. However, they have distinct pre/post processing requirements for each adapter. Given that the pre/post processing logic is tied to the adapter, it is necessary to manage them as a cohesive unit, ensuring they are created, updated, and deleted in unison.
What’s missing ? Currently, LMI supports custom pre/post processing scripts that are specified statically during the deployment of base models. However, LMI lacks the capability to dynamically register pre/post processing scripts at the time of adapter registration.
Design
Additional
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestVllm1" -m "vllm"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B