Skip to content

Cherry-pick Lora Fix #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksuma2109 merged 1 commit into from
Nov 20, 2025
Merged

Cherry-pick Lora Fix #2960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions engines/python/setup/djl_python/lmi_vllm/vllm_async_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,8 @@ async def add_lora(self, lora_name: str, lora_alias: str, lora_path: str):
logging.info(f"Adding LoRA {lora_name} from {lora_path}")
lora_id = self.lora_id_counter.inc(1)
lora_request = create_lora_request(lora_name, lora_id, lora_path, None)
# Register the LoRA request with the model registry so vLLM can find it
self.model_registry.lora_requests[lora_name] = lora_request
self.lora_requests[lora_request.lora_name] = lora_request
result = await self.vllm_engine.add_lora(lora_request)
logging.info(f"LoRA {lora_name} added to engine: {result}")
Expand All @@ -282,6 +284,7 @@ async def remove_lora(self, lora_name: str, lora_alias: str):
lora_request = get_lora_request(lora_name, self.lora_requests)
result = await self.vllm_engine.remove_lora(lora_request.lora_int_id)
del self.lora_requests[lora_name]
del self.model_registry.lora_requests[lora_name]
return result

async def pin_lora(self, lora_name: str, lora_alias: str):
Expand Down
Loading