Conversation
- product.md: Product overview, architecture, and use cases - tech.md: Technology stack, build system, and common commands - structure.md: Project organization, modules, and conventions - development.md: Development workflow, container builds, and CI/CD - partitioning.md: Model partitioning, quantization, and Neo integration - Updated .gitignore to track steering files while ignoring other .kiro/ content These steering documents provide essential context for AI assistants working in the DJL Serving codebase, covering product purpose, technical stack, project structure, development practices, and the model optimization system.
The test_lmcache_local_storage test was failing with FileExistsError because the /tmp/lmcache/ directory persisted between test runs. The LMCache library's LocalDiskBackend tries to create this directory without checking if it exists. Fix: - Clean up /tmp/lmcache directory in Runner.__init__ before each test - Clean up /tmp/lmcache directory in Runner.__exit__ after each test This ensures a clean state for lmcache tests and prevents directory conflicts between consecutive test runs. Error: FileExistsError: [Errno 17] File exists: '/tmp/lmcache/'
HappyAmazonian
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestVllm1" -m "vllm"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B